Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 527653002: X87: Refactoring InterfaceDescriptors away from code-stubs.h (Closed)

Created:
6 years, 3 months ago by chunyang.dai
Modified:
6 years, 3 months ago
Reviewers:
Weiliang, mvstanton
CC:
v8-dev, danno
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: Refactoring InterfaceDescriptors away from code-stubs.h port r23515. original commit message: Refactoring InterfaceDescriptors away from code-stubs.h Clean up and create seperation between the concept of a call descriptor and a code stub interface descriptor. The former is just concerned with how to call, but the latter has many extra hints related to code generation and deoptimization for the implementation of a particular code stub. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -79 lines) Patch
M src/x87/code-stubs-x87.cc View 2 chunks +0 lines, -77 lines 0 comments Download
A + src/x87/interface-descriptors-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
chunyang.dai
weiliang. PTAL. thanks
6 years, 3 months ago (2014-09-01 02:03:46 UTC) #2
mvstanton
lgtm
6 years, 3 months ago (2014-09-01 09:27:39 UTC) #3
Weiliang
On 2014/09/01 09:27:39, mvstanton wrote: > lgtm
6 years, 3 months ago (2014-09-01 14:00:58 UTC) #4
Weiliang
6 years, 3 months ago (2014-09-01 14:01:19 UTC) #5
Committed as r23568

Powered by Google App Engine
This is Rietveld 408576698