Use the "enum hack" to fix the SmiTagging constants.

Use the "enum hack" to fix the SmiTagging constants.

The "enum hack" (see Item 2 of "Effective C++") is the only known
portable way to define constant integral values within template
classes. Fixes the weird work-arounds required for certain GCC
versions.

R=jarin@chromium.org, rossberg@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=23550

[Benedikt Meurer, 2014-09-01 05:47:12]

bmeurer@chromium.org changed reviewers:
+ jarin@chromium.org

[Benedikt Meurer, 2014-09-01 05:47:13]

PTAL

[Jarin, 2014-09-01 06:20:21]

lgtm.

https://codereview.chromium.org/527603002/diff/40001/src/compiler/change-lowe...
File src/compiler/change-lowering.cc (right):

https://codereview.chromium.org/527603002/diff/40001/src/compiler/change-lowe...
src/compiler/change-lowering.cc:54: machine()->is32() ?
static_cast<int>(SmiTagging<4>::kSmiValueSize)
You might want to define a static method GetSmiValueSize() in SmiTagging<> to
encapsulate of the ugly cast (and possibly get rid of the enum).

[Benedikt Meurer, 2014-09-01 06:27:21]

bmeurer@chromium.org changed reviewers:
+ rossberg@chromium.org

[Benedikt Meurer, 2014-09-01 06:27:21]

Andreas: WDYT?

[rossberg, 2014-09-01 09:51:48]

lgtm

https://codereview.chromium.org/527603002/diff/40001/src/compiler/change-lowe...
File src/compiler/change-lowering.cc (right):

https://codereview.chromium.org/527603002/diff/40001/src/compiler/change-lowe...
src/compiler/change-lowering.cc:54: machine()->is32() ?
static_cast<int>(SmiTagging<4>::kSmiValueSize)
On 2014/09/01 06:20:21, jarin wrote:
> You might want to define a static method GetSmiValueSize() in SmiTagging<> to
> encapsulate of the ugly cast (and possibly get rid of the enum).

+1

[Benedikt Meurer, 2014-09-01 10:24:13]

Committed patchset #4 (id:60001) manually as 23550 (presubmit successful).