Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 527473002: athena: Add an accelerator to abort loading on escape. (Closed)

Created:
6 years, 3 months ago by sadrul
Modified:
6 years, 3 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, darin-cc_chromium.org, jam, Greg Levin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

athena: Add an accelerator to abort loading on escape. BUG=none R=mukai@chromium.org Committed: https://crrev.com/a81e61279429472fcc144eae56686041d312444f Cr-Commit-Position: refs/heads/master@{#292795}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M athena/content/web_activity.cc View 4 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sadrul
6 years, 3 months ago (2014-08-30 15:07:00 UTC) #2
Jun Mukai
lgtm Just in case to cc glevin, who is adding Esc handling to cancel overview ...
6 years, 3 months ago (2014-08-30 16:27:20 UTC) #3
sadrul
On 2014/08/30 16:27:20, Jun Mukai wrote: > lgtm > > Just in case to cc ...
6 years, 3 months ago (2014-08-30 16:42:40 UTC) #4
sadrul
Committed patchset #1 (id:1) manually as a81e612 (presubmit successful).
6 years, 3 months ago (2014-08-30 16:59:21 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:14:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a81e61279429472fcc144eae56686041d312444f
Cr-Commit-Position: refs/heads/master@{#292795}

Powered by Google App Engine
This is Rietveld 408576698