Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2815)

Unified Diff: chrome/browser/extensions/api/declarative/rules_cache_delegate.h

Issue 52743002: Declarative rules should be removed on uninstalling, not unloading (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Further comments addressed Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative/rules_cache_delegate.h
diff --git a/chrome/browser/extensions/api/declarative/rules_cache_delegate.h b/chrome/browser/extensions/api/declarative/rules_cache_delegate.h
index 8e502480b05dca73074072c416f9b7292e9eb510..7eccc8642cb0c74b1f70d937b882f83caf3bbabb 100644
--- a/chrome/browser/extensions/api/declarative/rules_cache_delegate.h
+++ b/chrome/browser/extensions/api/declarative/rules_cache_delegate.h
@@ -11,8 +11,6 @@
#include "base/gtest_prod_util.h"
#include "base/values.h"
#include "content/public/browser/browser_thread.h"
-#include "content/public/browser/notification_observer.h"
-#include "content/public/browser/notification_registrar.h"
class Profile;
@@ -24,7 +22,7 @@ class RulesRegistry;
// the UI thread. It should only be used on the UI thread.
// If |log_storage_init_delay| is set, the delay caused by loading and
// registering rules on initialization will be logged with UMA.
-class RulesCacheDelegate : public content::NotificationObserver {
+class RulesCacheDelegate {
public:
explicit RulesCacheDelegate(bool log_storage_init_delay);
@@ -56,11 +54,6 @@ class RulesCacheDelegate : public content::NotificationObserver {
static const char kRulesStoredKey[];
- // NotificationObserver
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) OVERRIDE;
-
// Check if we are done reading all data from storage on startup, and notify
// the RulesRegistry on its thread if so. The notification is delivered
// exactly once.
@@ -83,8 +76,6 @@ class RulesCacheDelegate : public content::NotificationObserver {
void SetDeclarativeRulesStored(const std::string& extension_id,
bool rules_stored);
- content::NotificationRegistrar registrar_;
-
Profile* profile_;
// The key under which rules are stored.

Powered by Google App Engine
This is Rietveld 408576698