chrome/browser/extensions/api/declarative/rules_registry_unittest.cc - Issue 52743002: Declarative rules should be removed on uninstalling, not unloading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_unittest.cc

Issue 52743002: Declarative rules should be removed on uninstalling, not unloading (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rewritten and rebased off https://codereview.chromium.org/64093010/ Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/declarative/rules_registry_service.cc ('K') | « chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc ('k') | chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/rules_registry_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative/rules_registry_unittest.cc b/chrome/browser/extensions/api/declarative/rules_registry_unittest.cc

index cc742c70d95173ea36cf345fdaab83d70076a388..3b50bc0e0de3c928169d0c91962e62acdc14c23a 100644

--- a/chrome/browser/extensions/api/declarative/rules_registry_unittest.cc

+++ b/chrome/browser/extensions/api/declarative/rules_registry_unittest.cc

@@ -119,7 +119,7 @@ TEST(RulesRegistryTest, FillOptionalIdentifiers) {

ASSERT_TRUE(get_rules_4b[0]->id.get());

EXPECT_EQ(kRuleId, *get_rules_4b[0]->id);

- registry->OnExtensionUnloaded(kExtensionId);

+ registry->OnExtensionUninstalled(kExtensionId);

EXPECT_EQ(0u /*extensions*/ + 0u /*rules*/,

registry->GetNumberOfUsedRuleIdentifiersForTesting());