Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: chrome/browser/extensions/api/declarative/rules_registry_unittest.cc

Issue 52743002: Declarative rules should be removed on uninstalling, not unloading (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Further comments addressed Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/declarative/rules_registry.h" 5 #include "chrome/browser/extensions/api/declarative/rules_registry.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "chrome/browser/extensions/api/declarative/test_rules_registry.h" 10 #include "chrome/browser/extensions/api/declarative/test_rules_registry.h"
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 registry->GetNumberOfUsedRuleIdentifiersForTesting()); 112 registry->GetNumberOfUsedRuleIdentifiersForTesting());
113 113
114 std::vector<linked_ptr<RulesRegistry::Rule> > get_rules_4b; 114 std::vector<linked_ptr<RulesRegistry::Rule> > get_rules_4b;
115 registry->GetAllRules(kExtensionId, &get_rules_4b); 115 registry->GetAllRules(kExtensionId, &get_rules_4b);
116 116
117 ASSERT_EQ(1u, get_rules_4b.size()); 117 ASSERT_EQ(1u, get_rules_4b.size());
118 118
119 ASSERT_TRUE(get_rules_4b[0]->id.get()); 119 ASSERT_TRUE(get_rules_4b[0]->id.get());
120 EXPECT_EQ(kRuleId, *get_rules_4b[0]->id); 120 EXPECT_EQ(kRuleId, *get_rules_4b[0]->id);
121 121
122 registry->OnExtensionUnloaded(kExtensionId); 122 registry->OnExtensionUninstalled(kExtensionId);
123 EXPECT_EQ(0u /*extensions*/ + 0u /*rules*/, 123 EXPECT_EQ(0u /*extensions*/ + 0u /*rules*/,
124 registry->GetNumberOfUsedRuleIdentifiersForTesting()); 124 registry->GetNumberOfUsedRuleIdentifiersForTesting());
125 125
126 // Make sure that deletion traits of registry are executed. 126 // Make sure that deletion traits of registry are executed.
127 registry = NULL; 127 registry = NULL;
128 message_loop.RunUntilIdle(); 128 message_loop.RunUntilIdle();
129 } 129 }
130 130
131 TEST(RulesRegistryTest, FillOptionalPriority) { 131 TEST(RulesRegistryTest, FillOptionalPriority) {
132 base::MessageLoopForUI message_loop; 132 base::MessageLoopForUI message_loop;
(...skipping 26 matching lines...) Expand all
159 EXPECT_EQ(2, std::min(*get_rules[0]->priority, *get_rules[1]->priority)); 159 EXPECT_EQ(2, std::min(*get_rules[0]->priority, *get_rules[1]->priority));
160 EXPECT_EQ(RulesRegistry::DEFAULT_PRIORITY, 160 EXPECT_EQ(RulesRegistry::DEFAULT_PRIORITY,
161 std::max(*get_rules[0]->priority, *get_rules[1]->priority)); 161 std::max(*get_rules[0]->priority, *get_rules[1]->priority));
162 162
163 // Make sure that deletion traits of registry are executed. 163 // Make sure that deletion traits of registry are executed.
164 registry = NULL; 164 registry = NULL;
165 message_loop.RunUntilIdle(); 165 message_loop.RunUntilIdle();
166 } 166 }
167 167
168 } // namespace extensions 168 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698