Declarative rules should be removed on uninstalling, not unloading

chrome/browser/extensions/api/declarative/rules_cache_delegate.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/declarative/rules_cache_delegate.h"
 
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/api/declarative/rules_registry.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
@@ skipping 61 matching lines @@
                                    profile_->IsOffTheRecord());
   rules_stored_key_ = GetRulesStoredKey(registry->event_name(),
                                         profile_->IsOffTheRecord());
   rules_registry_thread_ = registry->owner_thread();
 
   ExtensionSystem& system = *ExtensionSystem::Get(profile_);
   extensions::StateStore* store = system.rules_store();
   if (store)
     store->RegisterKey(storage_key_);
 
-  registrar_.Add(this,
-                 chrome::NOTIFICATION_EXTENSION_LOADED,
-                 content::Source<Profile>(profile_->GetOriginalProfile()));
-
   if (profile_->IsOffTheRecord())
     log_storage_init_delay_ = false;
 
   system.ready().Post(
       FROM_HERE,
       base::Bind(&RulesCacheDelegate::ReadRulesForInstalledExtensions,
                  weak_ptr_factory_.GetWeakPtr()));
   system.ready().Post(FROM_HERE,
                       base::Bind(&RulesCacheDelegate::CheckIfReady,
                                  weak_ptr_factory_.GetWeakPtr()));
@@ skipping 11 matching lines @@
   bool store_rules = !rules->empty();
   SetDeclarativeRulesStored(extension_id, store_rules);
   if (!rules_stored_previously && !store_rules)
     return;
 
   StateStore* store = ExtensionSystem::Get(profile_)->rules_store();
   if (store)
     store->SetExtensionValue(extension_id, storage_key_, value.Pass());
 }
 
-void RulesCacheDelegate::Observe(
-    int type,
-    const content::NotificationSource& source,
-    const content::NotificationDetails& details) {
-  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
-  DCHECK_EQ(chrome::NOTIFICATION_EXTENSION_LOADED, type);
-
-  const extensions::Extension* extension =
-      content::Details<const extensions::Extension>(details).ptr();
-  // TODO(mpcomplete): This API check should generalize to any use of
-  // declarative rules, not just webRequest.
-  if (extension->HasAPIPermission(APIPermission::kDeclarativeContent) ||
-      extension->HasAPIPermission(APIPermission::kDeclarativeWebRequest)) {
-    InfoMap* extension_info_map = ExtensionSystem::Get(profile_)->info_map();
-    if (profile_->IsOffTheRecord() &&
-        !extension_info_map->IsIncognitoEnabled(extension->id())) {
-      // Ignore this extension.
-    } else {
-      ReadFromStorage(extension->id());
-    }
-  }
-}
-
 void RulesCacheDelegate::CheckIfReady() {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   if (notified_registry_ || !waiting_for_extensions_.empty())
     return;
 
   content::BrowserThread::PostTask(
       rules_registry_thread_,
       FROM_HERE,
       base::Bind(
           &RulesRegistry::MarkReady, registry_, storage_init_time_));
@@ skipping 91 matching lines @@
     bool rules_stored) {
   CHECK(profile_);
   ExtensionScopedPrefs* extension_prefs = ExtensionPrefs::Get(profile_);
   extension_prefs->UpdateExtensionPref(
       extension_id,
       rules_stored_key_,
       new base::FundamentalValue(rules_stored));
 }
 
 }  // namespace extensions