Issue 527423002: SkRecordPartialDraw with less code duplication

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 527423002: SkRecordPartialDraw with less code duplication (Closed)

Created:
6 years, 3 months ago by mtklein_C

Modified:
6 years, 3 months ago

Reviewers:
mtklein, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -15 lines)			Patch
M	src/core/SkRecordDraw.h	View	1	2 chunks	+26 lines, -5 lines	0 comments	Download
M	src/core/SkRecordDraw.cpp	View	1	1 chunk	+16 lines, -2 lines	0 comments	Download
M	tests/RecordDrawTest.cpp	View	1	1 chunk	+52 lines, -0 lines	0 comments	Download
M	tools/DumpRecord.cpp	View		5 chunks	+6 lines, -8 lines	0 comments	Download

Total messages: 5 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/527423002/20001

6 years, 3 months ago (2014-09-02 18:53:59 UTC) #4

commit-bot: I haz the power

6 years, 3 months ago (2014-09-02 19:03:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 00f30bdc9e34b013da54b4406f36556c5be8d041