Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 527293002: ozone: Remove CursorFactoryOzone::SetCursor, GetCursorWindow (Closed)

Created:
6 years, 3 months ago by spang
Modified:
6 years, 3 months ago
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ozone: Remove CursorFactoryOzone::SetCursor, GetCursorWindow Use PlatformWindow::SetCursor instead of CursorFactoryOzone::SetCursor. The GetCursorWindow() function becomes an implementation detail of the DRI platform. BUG=none TEST=compile, run on cros link_freon NOTRY=true Committed: https://crrev.com/11127567cfcddd0f2bf2efe00ae8744f780058f5 Cr-Commit-Position: refs/heads/master@{#293033}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -282 lines) Patch
M ui/base/cursor/ozone/bitmap_cursor_factory_ozone.h View 1 chunk +4 lines, -7 lines 0 comments Download
M ui/base/cursor/ozone/bitmap_cursor_factory_ozone.cc View 2 chunks +6 lines, -12 lines 0 comments Download
M ui/ozone/platform/dri/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D ui/ozone/platform/dri/cursor_factory_evdev_dri.h View 1 chunk +0 lines, -57 lines 0 comments Download
D ui/ozone/platform/dri/cursor_factory_evdev_dri.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M ui/ozone/platform/dri/dri.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/ozone/platform/dri/dri_cursor.h View 2 chunks +17 lines, -16 lines 0 comments Download
A + ui/ozone/platform/dri/dri_cursor.cc View 3 chunks +22 lines, -14 lines 0 comments Download
M ui/ozone/platform/dri/dri_window.h View 3 chunks +4 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_window.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_dri.cc View 4 chunks +10 lines, -7 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_gbm.cc View 4 chunks +10 lines, -7 lines 0 comments Download
M ui/ozone/platform/egltest/ozone_platform_egltest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/test/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/ozone/platform/test/ozone_platform_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/test/test.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
D ui/ozone/platform/test/test_cursor_factory.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/ozone/platform/test/test_cursor_factory.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M ui/ozone/public/cursor_factory_ozone.h View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/ozone/public/cursor_factory_ozone.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
spang
6 years, 3 months ago (2014-09-02 13:44:30 UTC) #2
dnicoara
lgtm
6 years, 3 months ago (2014-09-02 14:05:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/527293002/20001
6 years, 3 months ago (2014-09-02 22:07:47 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 663900b37c75c757bfcde5fe6c077e9b2bd19d3d
6 years, 3 months ago (2014-09-03 00:57:14 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:22:19 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/11127567cfcddd0f2bf2efe00ae8744f780058f5
Cr-Commit-Position: refs/heads/master@{#293033}

Powered by Google App Engine
This is Rietveld 408576698