Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 527273003: Fix NaCl build. (Closed)

Created:
6 years, 3 months ago by Jarin
Modified:
6 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M src/base/bits-unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/base/platform/semaphore.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jarin
Could you take a quick look?
6 years, 3 months ago (2014-09-02 15:20:57 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
6 years, 3 months ago (2014-09-02 15:21:50 UTC) #2
Jarin
6 years, 3 months ago (2014-09-02 15:22:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23625 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698