Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 527233003: Parser cleanup: less member variables. (Closed)

Created:
6 years, 3 months ago by marja
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Parser cleanup: less member variables. Parser had unnecessary member pointers to stuff stored in the CompilationInfo (which Parser also points to). As we add more parsing code paths (in particular, script streaming), this gets confusing and Parser and CompilationInfo can get out of sync. BUG= R=jochen@chromium.org, rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23861

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -81 lines) Patch
M src/parser.h View 4 chunks +7 lines, -7 lines 0 comments Download
M src/parser.cc View 41 chunks +65 lines, -74 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
marja
rossberg, ptal
6 years, 3 months ago (2014-09-02 15:45:13 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-04 13:11:34 UTC) #4
rossberg
lgtm
6 years, 3 months ago (2014-09-08 14:11:27 UTC) #5
marja
6 years, 3 months ago (2014-09-11 09:52:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23861 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698