Issue 52723009: [android_webview] Fix findbugs warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 52723009: [android_webview] Fix findbugs warnings. (Closed)

Created:
7 years, 1 month ago by mkosiba (inactive)

Modified:
7 years, 1 month ago

Reviewers:
Primiano Tucci (use gerrit), benm (inactive)

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, android-webview-reviews_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[android_webview] Fix findbugs warnings. Refactor the code a bit and don't ignore return value of delete(). BUG=230209 TEST=AndroidWebViewTest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232522

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -15 lines)			Patch
	M	android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java	View		4 chunks	+11 lines, -11 lines	0 comments	Download
	M	build/android/findbugs_filter/findbugs_known_bugs.txt	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/52723009/1

7 years, 1 month ago (2013-11-01 17:12:20 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=170719

7 years, 1 month ago (2013-11-01 19:10:10 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/52723009/1

7 years, 1 month ago (2013-11-01 22:36:10 UTC) #6

Message was sent while issue was closed.

Change committed as 232522

Expand Messages | Collapse Messages