Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 527203002: Experimental app list: Remove start page button. (Closed)

Created:
6 years, 3 months ago by Matt Giuca
Modified:
6 years, 3 months ago
Reviewers:
calamity, oshima
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Experimental app list: Remove start page button. We're experimenting with a minimal UI and there is no real need to have this button since you don't need to get back to the start page if you find yourself on some other page. BUG=406222 Committed: https://crrev.com/6af92606baf85644f362190b2036eff65fa89615 Cr-Commit-Position: refs/heads/master@{#293066}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M ui/app_list/views/contents_view.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
D ui/resources/default_100_percent/common/app_list_search_icon.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/app_list_search_icon.png View Binary file 0 comments Download
M ui/resources/ui_resources.grd View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
Matt Giuca
calamity: ui/app_list oshima: ui/resources thanks!
6 years, 3 months ago (2014-09-02 07:47:13 UTC) #2
calamity
lgtm.
6 years, 3 months ago (2014-09-02 07:55:10 UTC) #3
oshima
lgtm
6 years, 3 months ago (2014-09-02 22:24:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/527203002/1
6 years, 3 months ago (2014-09-03 00:03:15 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-09-03 00:31:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/49323) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/8283) mac_chromium_compile_dbg ...
6 years, 3 months ago (2014-09-03 00:34:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/527203002/20001
6 years, 3 months ago (2014-09-03 00:44:18 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-09-03 02:21:28 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 11c0daf252256bc42b2dfb5757f6376147fa36ac
6 years, 3 months ago (2014-09-03 04:44:29 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:23:24 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6af92606baf85644f362190b2036eff65fa89615
Cr-Commit-Position: refs/heads/master@{#293066}

Powered by Google App Engine
This is Rietveld 408576698