Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 527193003: Remove invalid link_settings from target condition. (Closed)

Created:
6 years, 3 months ago by Torne
Modified:
6 years, 3 months ago
Base URL:
https://chromium.googlesource.com/chromium/deps/icu52.git@master
Visibility:
Public.

Description

Remove invalid link_settings from target condition. ICU fails to gyp when run with GYP_DEFINES="android_webview_build=1 use_system_icu=0 use_system_stlport=1" which is a combination of settings we're trying to bring up temporarily as we migrate away from system libraries. It fails because it's not permitted to specify link_settings in a target_condition as the processing is too late. Remove the invalid link_settings, since we can't do this outside target_conditions as it's not valid to use -lgabi++ on the host build of ICU. The link dependency on gabi++ will have to be satisfied manually in the main libwebviewchromium target instead for this configuration. BUG=409851 R=mkosiba@chromium.org TBR=jshin@chromium.org Committed: 291781

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M icu.gyp View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Torne
Hi Jungshik, can you take a look at this and land it if it's okay? ...
6 years, 3 months ago (2014-09-02 17:14:39 UTC) #2
Torne
6 years, 3 months ago (2014-09-03 10:14:10 UTC) #4
Torne
Will TBR jshin@ as this is a build fix for a configuration not currently used ...
6 years, 3 months ago (2014-09-03 10:23:52 UTC) #6
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 3 months ago (2014-09-03 10:26:27 UTC) #9
mkosiba (inactive)
lgtm
6 years, 3 months ago (2014-09-03 11:10:17 UTC) #11
Torne
6 years, 3 months ago (2014-09-03 11:10:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 291781 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698