DescriptionRemove invalid link_settings from target condition.
ICU fails to gyp when run with GYP_DEFINES="android_webview_build=1
use_system_icu=0 use_system_stlport=1" which is a combination of
settings we're trying to bring up temporarily as we migrate away from
system libraries. It fails because it's not permitted to specify
link_settings in a target_condition as the processing is too late.
Remove the invalid link_settings, since we can't do this outside
target_conditions as it's not valid to use -lgabi++ on the host build of
ICU. The link dependency on gabi++ will have to be satisfied manually in
the main libwebviewchromium target instead for this configuration.
BUG=409851
R=mkosiba@chromium.org
TBR=jshin@chromium.org
Committed: 291781
Patch Set 1 #Messages
Total messages: 12 (6 generated)
|