Support CanvasPattern.setTransform

Support CanvasPattern.setTransform

Patterns have a transformation matrix, which controls how the pattern is used when it is painted. 

Initially, a pattern's transformation matrix must be the identity transform. 

When the setTransform() method is invoked on the pattern, the user agent must replace the pattern's
transformation matrix with the one described by the SVGMatrix object provided as an argument to the method.

Specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-canvaspattern-settransform
IDL Definition: http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting.html#2dcontext:dom-canvaspattern-settransform
Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dUt2_2xn3NU

BUG=289572
R=junov@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181737

[pavane, 2014-09-03 11:03:24]

Please take a look

[Justin Novosad, 2014-09-03 15:04:35]

On 2014/09/03 11:03:24, pavane wrote:
> Please take a look

The code looks good, but I did not see an intent thread about this on blink-dev.
You need to follow the launch process:
http://www.chromium.org/blink#TOC-Web-Platform-Changes:-Process

[pavane, 2014-09-04 07:17:21]

Patchset #2 (id:20001) has been deleted

[pavane, 2014-09-04 07:23:30]

On 2014/09/03 15:04:35, junov wrote:
> On 2014/09/03 11:03:24, pavane wrote:
> > Please take a look
> 
> The code looks good, but I did not see an intent thread about this on
blink-dev.
> You need to follow the launch process:
> http://www.chromium.org/blink#TOC-Web-Platform-Changes:-Process

@junov, thanks for the review.

I raised an intent thread for this feature
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dUt2_2xn3NU

Please have a look.

[pavane, 2014-09-09 13:55:11]

Hi Junov, i am not so much familiar with intent mails. How long are we supposed
to wait to check-in this cl?

[Rik, 2014-09-09 16:16:30]

On 2014/09/09 13:55:11, pavane wrote:
> Hi Junov, i am not so much familiar with intent mails. How long are we
supposed
> to wait to check-in this cl?

You are good to go! "week in blink intent" said that lgtm was not necessary

[Justin Novosad, 2014-09-09 16:54:33]

On 2014/09/09 13:55:11, pavane wrote:
> Hi Junov, i am not so much familiar with intent mails. How long are we
supposed
> to wait to check-in this cl?

It has been long enough.  Later when you post an intent to ship, you will have
to wait to get 3 lgtms from blink API owners.
Because you sent an intent to implement (as opposed to ship), you have to put
the feature behind a flag. To do so, you should add
[RuntimeEnabled=ExperimentalCanvasFeatures] to the IDL.

[Justin Novosad, 2014-09-09 19:43:50]

On 2014/09/09 16:54:33, junov wrote:
> You have to put the feature behind a flag. To do so, you should add
> [RuntimeEnabled=ExperimentalCanvasFeatures] to the IDL.

To be clear: not lgtm

[Rik, 2014-09-10 01:05:36]

On 2014/09/09 19:43:50, junov wrote:
> On 2014/09/09 16:54:33, junov wrote:
> > You have to put the feature behind a flag. To do so, you should add
> > [RuntimeEnabled=ExperimentalCanvasFeatures] to the IDL.
> 
> To be clear: not lgtm

sorry, I didn't mean to approve the bug.

[pavane, 2014-09-10 06:09:03]

@Rik and Junov, thanks for your response.

Now, this feature is pushed under a runtime flag. Please have a look once again.

[Justin Novosad, 2014-09-10 14:37:29]

lgtm

No worries Rik.

[pavane, 2014-09-10 14:45:34]

The CQ bit was checked by pavan.e@samsung.com

[commit-bot: I haz the power, 2014-09-10 14:46:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pavan.e@samsung.com/527193002/120001

[commit-bot: I haz the power, 2014-09-10 15:47:10]

Committed patchset #6 (id:120001) as 181737