Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 527183002: Oilpan: Prepare moving InspectorResourceContentLoader to Oilpan (Closed)

Created:
6 years, 3 months ago by keishi
Modified:
6 years, 3 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Oilpan: Prepare moving InspectorResourceContentLoader to Oilpan BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181437

Patch Set 1 #

Total comments: 3

Patch Set 2 : added InspectorResourceContentLoader::dispose #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -8 lines) Patch
M Source/core/inspector/InspectorPageAgent.h View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 2 3 4 5 3 chunks +16 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorResourceContentLoader.h View 1 2 chunks +6 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorResourceContentLoader.cpp View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
keishi
Addressing the fixme
6 years, 3 months ago (2014-09-02 06:47:04 UTC) #2
sof
lgtm https://codereview.chromium.org/527183002/diff/1/Source/core/inspector/InspectorPageAgent.cpp File Source/core/inspector/InspectorPageAgent.cpp (right): https://codereview.chromium.org/527183002/diff/1/Source/core/inspector/InspectorPageAgent.cpp#newcode483 Source/core/inspector/InspectorPageAgent.cpp:483: m_inspectorResourceContentLoader = adoptPtrWillBeNoop(new InspectorResourceContentLoader(m_page)); nit: for consistency, having ...
6 years, 3 months ago (2014-09-02 07:02:32 UTC) #4
haraken
https://codereview.chromium.org/527183002/diff/1/Source/core/inspector/InspectorResourceContentLoader.cpp File Source/core/inspector/InspectorResourceContentLoader.cpp (right): https://codereview.chromium.org/527183002/diff/1/Source/core/inspector/InspectorResourceContentLoader.cpp#newcode158 Source/core/inspector/InspectorResourceContentLoader.cpp:158: stop(); stop() touches m_callbacks. We're not allowed to touch ...
6 years, 3 months ago (2014-09-02 07:19:01 UTC) #5
keishi
6 years, 3 months ago (2014-09-02 09:08:09 UTC) #6
keishi
https://codereview.chromium.org/527183002/diff/1/Source/core/inspector/InspectorResourceContentLoader.cpp File Source/core/inspector/InspectorResourceContentLoader.cpp (right): https://codereview.chromium.org/527183002/diff/1/Source/core/inspector/InspectorResourceContentLoader.cpp#newcode158 Source/core/inspector/InspectorResourceContentLoader.cpp:158: stop(); On 2014/09/02 07:19:00, haraken wrote: > > stop() ...
6 years, 3 months ago (2014-09-02 09:08:51 UTC) #7
haraken
LGTM https://codereview.chromium.org/527183002/diff/20001/Source/core/inspector/InspectorResourceContentLoader.cpp File Source/core/inspector/InspectorResourceContentLoader.cpp (right): https://codereview.chromium.org/527183002/diff/20001/Source/core/inspector/InspectorResourceContentLoader.cpp#newcode157 Source/core/inspector/InspectorResourceContentLoader.cpp:157: { Shall we add some ASSERT to check ...
6 years, 3 months ago (2014-09-02 09:15:40 UTC) #8
keishi
https://codereview.chromium.org/527183002/diff/20001/Source/core/inspector/InspectorResourceContentLoader.cpp File Source/core/inspector/InspectorResourceContentLoader.cpp (right): https://codereview.chromium.org/527183002/diff/20001/Source/core/inspector/InspectorResourceContentLoader.cpp#newcode157 Source/core/inspector/InspectorResourceContentLoader.cpp:157: { On 2014/09/02 09:15:40, haraken wrote: > > Shall ...
6 years, 3 months ago (2014-09-02 11:10:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/527183002/60001
6 years, 3 months ago (2014-09-02 11:11:32 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 3 months ago (2014-09-02 11:53:28 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/23562)
6 years, 3 months ago (2014-09-02 12:59:35 UTC) #14
vsevik
https://codereview.chromium.org/527183002/diff/60001/Source/core/inspector/InspectorController.cpp File Source/core/inspector/InspectorController.cpp (right): https://codereview.chromium.org/527183002/diff/60001/Source/core/inspector/InspectorController.cpp#newcode218 Source/core/inspector/InspectorController.cpp:218: m_agents.discardAgents(); discardAgents calls virtual discardAgent method on each agent. ...
6 years, 3 months ago (2014-09-02 13:24:33 UTC) #17
keishi
On 2014/09/02 13:24:33, vsevik wrote: > https://codereview.chromium.org/527183002/diff/60001/Source/core/inspector/InspectorController.cpp > File Source/core/inspector/InspectorController.cpp (right): > > https://codereview.chromium.org/527183002/diff/60001/Source/core/inspector/InspectorController.cpp#newcode218 > ...
6 years, 3 months ago (2014-09-05 04:14:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/527183002/100001
6 years, 3 months ago (2014-09-05 04:15:52 UTC) #20
commit-bot: I haz the power
6 years, 3 months ago (2014-09-05 05:31:41 UTC) #21
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as 181437

Powered by Google App Engine
This is Rietveld 408576698