Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 52713012: Remove display:compact as per https://groups.google.com/a/chromium.org/d/topic/blink-dev/j6QErzkX4R… (Closed)

Created:
7 years, 1 month ago by ojan
Modified:
7 years, 1 month ago
CC:
blink-reviews, chromiumbugtracker_adobe.com, zoltan1, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears
Visibility:
Public.

Description

Remove display:compact as per https://groups.google.com/a/chromium.org/d/topic/blink-dev/j6QErzkX4RE/discussion. display: compact does the same thing as display: block and is only in WebKit/Blink browsers. It's used on 0.02% of pageviews, but for many of those uses it's likely used on a block anyways, so the likelihood of removing this breaking content is quite low. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161092

Patch Set 1 #

Patch Set 2 : try again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M LayoutTests/fast/regions/region-element-display-change-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/regions/region-element-display-restriction-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/regions/script-tests/region-element-display-change.js View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/regions/script-tests/region-element-display-restriction.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderObject.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyleConstants.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ojan
7 years, 1 month ago (2013-10-31 19:38:22 UTC) #1
esprehn
lgtm
7 years, 1 month ago (2013-10-31 19:42:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/52713012/130001
7 years, 1 month ago (2013-10-31 19:42:23 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 20:37:01 UTC) #4
Message was sent while issue was closed.
Change committed as 161092

Powered by Google App Engine
This is Rietveld 408576698