Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 52713010: Remove reference to missing assets. 140 and 180 have been removed. (Closed)

Created:
7 years, 1 month ago by girard
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove reference to missing assets. 140 and 180 have been removed. Also fixes issues 223928, 261365, 261992, 261994, 267015, 281758 BUG=260703 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232633

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M ui/base/resource/resource_bundle.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
girard
Many UI defects were caused by missing assets.
7 years, 1 month ago (2013-10-31 18:08:51 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 1 month ago (2013-10-31 18:15:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/girard@chromium.org/52713010/1
7 years, 1 month ago (2013-10-31 23:43:23 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=217113
7 years, 1 month ago (2013-11-01 03:36:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/girard@chromium.org/52713010/1
7 years, 1 month ago (2013-11-02 01:21:02 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-02 04:01:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/girard@chromium.org/52713010/40003
7 years, 1 month ago (2013-11-02 05:37:35 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=96756
7 years, 1 month ago (2013-11-02 08:33:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/girard@chromium.org/52713010/40003
7 years, 1 month ago (2013-11-02 08:42:48 UTC) #9
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=96777
7 years, 1 month ago (2013-11-02 12:31:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/girard@chromium.org/52713010/40003
7 years, 1 month ago (2013-11-02 17:13:43 UTC) #11
commit-bot: I haz the power
7 years, 1 month ago (2013-11-02 18:06:28 UTC) #12
Message was sent while issue was closed. 
Change committed as 232633

Powered by Google App Engine
This is Rietveld 408576698