Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 52713008: Adding UMA statistics for multi profile (Closed)

Created:
7 years, 1 month ago by Mr4D (OOO till 08-26)
Modified:
7 years, 1 month ago
Reviewers:
Mark P, sky
CC:
chromium-reviews, sadrul, jar (doing other things), asvitkine+watch_chromium.org, kalyank, Ilya Sherman, ben+ash_chromium.org
Visibility:
Public.

Description

Adding UMA statistics for multi profile We are capturing: - The used multi profile mode - Window teleports (and their type of transfer) BUG=311828 TEST=visual using chrome://histograms page Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232355

Patch Set 1 #

Total comments: 9

Patch Set 2 : changed xml comments #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -9 lines) Patch
M ash/multi_profile_uma.h View 2 chunks +27 lines, -6 lines 0 comments Download
M ash/multi_profile_uma.cc View 2 chunks +17 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/multi_user_window_manager.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 4 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Mr4D (OOO till 08-26)
Please have a look!
7 years, 1 month ago (2013-10-31 17:25:51 UTC) #1
sky
LGTM
7 years, 1 month ago (2013-10-31 17:57:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/52713008/1
7 years, 1 month ago (2013-10-31 18:09:24 UTC) #3
Mr4D (OOO till 08-26)
+mpearson can you please do an owners review for histograms.xls? Many thanks in advance!
7 years, 1 month ago (2013-10-31 18:29:59 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=33726
7 years, 1 month ago (2013-10-31 18:32:00 UTC) #5
Mark P
https://codereview.chromium.org/52713008/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/52713008/diff/1/tools/metrics/histograms/histograms.xml#newcode6811 tools/metrics/histograms/histograms.xml:6811: + The counter for different multi profile modes selected ...
7 years, 1 month ago (2013-10-31 18:56:26 UTC) #6
Mr4D (OOO till 08-26)
Changed - see again https://codereview.chromium.org/52713008/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/52713008/diff/1/tools/metrics/histograms/histograms.xml#newcode6811 tools/metrics/histograms/histograms.xml:6811: + The counter for different ...
7 years, 1 month ago (2013-10-31 19:11:40 UTC) #7
Mark P
lgtm once you fix the minor comment below. https://codereview.chromium.org/52713008/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/52713008/diff/1/tools/metrics/histograms/histograms.xml#newcode6811 tools/metrics/histograms/histograms.xml:6811: + ...
7 years, 1 month ago (2013-10-31 21:36:19 UTC) #8
Mr4D (OOO till 08-26)
Many thanks! https://codereview.chromium.org/52713008/diff/180003/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/52713008/diff/180003/tools/metrics/histograms/histograms.xml#newcode6810 tools/metrics/histograms/histograms.xml:6810: + <summary>The session counter for different multi ...
7 years, 1 month ago (2013-10-31 21:51:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/52713008/350001
7 years, 1 month ago (2013-10-31 23:43:09 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, chrome_frame_net_tests, chrome_frame_tests, chrome_frame_unittests, content_browsertests, mini_installer_test, ...
7 years, 1 month ago (2013-11-01 01:43:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/52713008/350001
7 years, 1 month ago (2013-11-01 01:56:02 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=217160
7 years, 1 month ago (2013-11-01 03:48:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/52713008/350001
7 years, 1 month ago (2013-11-01 03:51:58 UTC) #14
commit-bot: I haz the power
7 years, 1 month ago (2013-11-01 13:35:23 UTC) #15
Message was sent while issue was closed.
Change committed as 232355

Powered by Google App Engine
This is Rietveld 408576698