Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 52713007: [NaCL SDK] Roll naclports revision. (Closed)

Created:
7 years, 1 month ago by Sam Clegg
Modified:
7 years, 1 month ago
Reviewers:
binji
CC:
chromium-reviews, binji
Visibility:
Public.

Description

[NaCL SDK] Roll naclports revision. Roll naclports 850 -> 954. This fixes the accidental include of the supplemental newlib headers in the ports bundle. Most of the changes in the range we are pulling in are unrelated to the ports that we ship. A lot of them are build script related and adding of new ports. The revisions of interest are: 949 - Add port of lua 5.2 and use it in lua_ppapi example. 948 - Fix accidental modification of top level sdklibs target. The former changes the default lua version from 5.1 to 5.2 which means we will now be shipping liblua 5.2 in the SDK. The latter removes the accidentally included headers which actually fixes bug 313403. R=binji@chromium.org, binji BUG=313403 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232167

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 3 chunks +3 lines, -2 lines 4 comments Download

Messages

Total messages: 5 (0 generated)
Sam Clegg
7 years, 1 month ago (2013-10-31 16:28:00 UTC) #1
binji
This pulls in a lot of new CLs. What will change in the SDK aside ...
7 years, 1 month ago (2013-10-31 16:34:36 UTC) #2
Sam Clegg
ptal. https://codereview.chromium.org/52713007/diff/1/native_client_sdk/src/build_tools/build_sdk.py File native_client_sdk/src/build_tools/build_sdk.py (right): https://codereview.chromium.org/52713007/diff/1/native_client_sdk/src/build_tools/build_sdk.py#newcode57 native_client_sdk/src/build_tools/build_sdk.py:57: NACLPORTS_REV = 954 On 2013/10/31 16:34:36, binji wrote: ...
7 years, 1 month ago (2013-10-31 16:54:15 UTC) #3
binji
cool, lgtm
7 years, 1 month ago (2013-10-31 16:56:21 UTC) #4
Sam Clegg
7 years, 1 month ago (2013-10-31 18:11:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r232167 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698