Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: components/autofill/core/browser/personal_data_manager.h

Issue 52713006: Parameterize the PrefService that PersonalDataManager uses. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/personal_data_manager.h
diff --git a/components/autofill/core/browser/personal_data_manager.h b/components/autofill/core/browser/personal_data_manager.h
index 40d5159135bd7f29979c50b44e798ad4a9a99f49..3134d7391fcdbb83bd4037ade118151673f075fc 100644
--- a/components/autofill/core/browser/personal_data_manager.h
+++ b/components/autofill/core/browser/personal_data_manager.h
@@ -19,6 +19,7 @@
#include "components/autofill/core/browser/webdata/autofill_webdata_service_observer.h"
#include "components/webdata/common/web_data_service_consumer.h"
+class PrefService;
class RemoveAutofillTester;
namespace content {
@@ -55,7 +56,7 @@ class PersonalDataManager : public WebDataServiceConsumer,
virtual ~PersonalDataManager();
// Kicks off asynchronous loading of profiles and credit cards.
- void Init(content::BrowserContext* context);
+ void Init(content::BrowserContext* context, PrefService* pref_service);
// WebDataServiceConsumer:
virtual void OnWebDataServiceRequestDone(
@@ -299,6 +300,9 @@ class PersonalDataManager : public WebDataServiceConsumer,
// For logging UMA metrics. Overridden by metrics tests.
scoped_ptr<const AutofillMetrics> metric_logger_;
+ // The PrefService that this class uses.
Jói 2013/10/31 17:23:05 Document the lifetime guarantees. I'm guessing in
blundell 2013/11/03 21:33:03 Done.
+ PrefService* pref_service_;
+
// Whether we have already logged the number of profiles this session.
mutable bool has_logged_profile_count_;

Powered by Google App Engine
This is Rietveld 408576698