Parameterize the PrefService that PersonalDataManager uses.

Parameterize the PrefService that PersonalDataManager uses.

Rather than having PersonalDataManager obtain the PrefService that it uses from
its BrowserContext, have the client pass in the PrefService to use.
Incremental step toward abstracting BrowserContext knowledge out of
PersonalDataManager.

BUG=303050
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232798

[Jói, 2013-10-31 17:23:05]

LGTM with documentation nit.

https://codereview.chromium.org/52713006/diff/50001/components/autofill/core/...
File components/autofill/core/browser/personal_data_manager.h (right):

https://codereview.chromium.org/52713006/diff/50001/components/autofill/core/...
components/autofill/core/browser/personal_data_manager.h:303: // The PrefService
that this class uses.
Document the lifetime guarantees. I'm guessing in this case it's guaranteed by
the caller to exceed the lifetime of this object... in which case that should be
documented on the constructor where the pointer is passed in.

[Ilya Sherman, 2013-10-31 21:09:19]

*/autofill/* lgtm with Jói's nit addressed.

[Ilya Sherman, 2013-10-31 21:10:28]

zea@chromium.org: Please review changes in chrome/browser/sync.

[Nicolas Zea, 2013-10-31 22:33:16]

lgtm

[blundell, 2013-11-03 21:33:03]

Hi Jói,

I had to add a PrefService setter to PersonalDataManager for a couple tests that
set state manually on the PDM that they are using. Could you do a review over
the delta between PS2 and PS3?

Thanks,

Colin

https://codereview.chromium.org/52713006/diff/50001/components/autofill/core/...
File components/autofill/core/browser/personal_data_manager.h (right):

https://codereview.chromium.org/52713006/diff/50001/components/autofill/core/...
components/autofill/core/browser/personal_data_manager.h:303: // The PrefService
that this class uses.
On 2013/10/31 17:23:05, Jói wrote:
> Document the lifetime guarantees. I'm guessing in this case it's guaranteed by
> the caller to exceed the lifetime of this object... in which case that should
be
> documented on the constructor where the pointer is passed in.

Done.

[Jói, 2013-11-04 10:45:18]

LGTM

[commit-bot: I haz the power, 2013-11-04 10:46:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/52713006/410001

[commit-bot: I haz the power, 2013-11-04 12:41:38]

Retried try job too often on win_rel for step(s) content_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-04 12:44:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/52713006/410001

[commit-bot: I haz the power, 2013-11-04 17:43:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/52713006/410001

[commit-bot: I haz the power, 2013-11-04 21:15:14]

Change committed as 232798