Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 527103004: Lengthen lastchange VERSION string to show full hash and commit position. (Closed)

Created:
6 years, 3 months ago by agable
Modified:
6 years, 3 months ago
Reviewers:
Joao da Silva, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Lengthen lastchange VERSION string to show full hash and commit position. Now that the DMServer has been fixed to accept 'agent' strings longer than 64 characters (http://crbug.com/406948), we can re-lengthen the string produced by lastchange.py to include both the full git hash and the Cr-Commit-Position. R=joaodasilva@chromium.org, scottmg@chromium.org BUG=406783 Committed: https://crrev.com/740c00432f11b2378fcb2cc72e09dd0c9a74e62f Cr-Commit-Position: refs/heads/master@{#292963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M build/util/lastchange.py View 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
agable
6 years, 3 months ago (2014-09-02 16:53:31 UTC) #1
scottmg
lgtm
6 years, 3 months ago (2014-09-02 17:05:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agable@chromium.org/527103004/1
6 years, 3 months ago (2014-09-02 17:25:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 091a8710b85587017b1abade341d61084fdbb5ef
6 years, 3 months ago (2014-09-02 18:35:22 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:19:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/740c00432f11b2378fcb2cc72e09dd0c9a74e62f
Cr-Commit-Position: refs/heads/master@{#292963}

Powered by Google App Engine
This is Rietveld 408576698