Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 527073003: Add gamma/sRGB tag to SkImageInfo (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add gamma/sRGB tag to SkImageInfo This reverts commit 1cbc68f9659f15206d920dacd434ddf4b658ad1f. requires this to land in blink https://codereview.chromium.org/531883002/ Committed: https://skia.googlesource.com/skia/+/2f6abdecc5c2f21da13003c615903679abc73fc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -46 lines) Patch
M gyp/tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkImageInfo.h View 4 chunks +71 lines, -25 lines 0 comments Download
M src/core/SkImageInfo.cpp View 2 chunks +111 lines, -21 lines 0 comments Download
A tests/ImageInfoTest.cpp View 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
reed1
6 years, 3 months ago (2014-09-02 18:59:42 UTC) #2
reed2
lgtm
6 years, 3 months ago (2014-09-03 04:48:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/527073003/1
6 years, 3 months ago (2014-09-03 04:49:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2f6abdecc5c2f21da13003c615903679abc73fc7
6 years, 3 months ago (2014-09-03 04:56:46 UTC) #7
reed1
6 years, 3 months ago (2014-09-03 12:48:33 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/535113002/ by reed@google.com.

The reason for reverting is: virtual gpu failures in layouttests

http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...

[6:6:0903/041147:1700960503:INFO:SkBitmap.cpp(1003)]
../../third_party/skia/src/core/SkBitmap.cpp:1003: failed assertion
"fPixelRef->info() == pixelRef->info()"

[6:6:0903/041147:1700961002:FATAL:SkBitmap.cpp(1003)] SK_CRASH
#0 0x7f9867df2c1e base::debug::StackTrace::StackTrace()
#1 0x7f9867e89e05 logging::LogMessage::~LogMessage()
#2 0x7f98689c4970 SkDebugf_FileLine()
#3 0x7f986870ebc6 SkBitmap::deepCopyTo()
#4 0x7f98690a3b6d blink::deepSkBitmapCopy()
#5 0x7f98690a3abe blink::ImageBuffer::copyImage()
#6 0x7f985fd4479e blink::ImageBitmap::ImageBitmap()
#7 0x7f985fd45942 blink::ImageBitmap::create()
#8 0x7f985fd84fdc blink::ImageBitmapFactories::createImageBitmap()
#9 0x7f985fd84d11 blink::ImageBitmapFactories::createImageBitmap()
#10 0x7f985ec9a7f2 blink::LocalDOMWindowV8Internal::createImageBitmap13Method()
#11 0x7f985ec96b0c blink::LocalDOMWindowV8Internal::createImageBitmapMethod()
#12 0x7f985ec91954
blink::LocalDOMWindowV8Internal::createImageBitmapMethodCallback()
#13 0x7f9869955af0 v8::internal::FunctionCallbackArguments::Call()
#14 0x7f98699833bd v8::internal::Builtin_HandleApiCall()
.

Powered by Google App Engine
This is Rietveld 408576698