Chromium Code Reviews
Help | Chromium Project | Sign in
(25)

Issue 527009: Removing the dependency of command-buffer client on base/task.h. This file in... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 4 months ago by Alok Priyadarshi
Modified:
3 years, 11 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam, pam+watch_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Removing the dependency of command-buffer client on base/task.h. This file includes base/logging.h which is difficult to compile under nacl. base-logging is stubbed in gpu by gpu/common/logging.h. BUG=26104 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35860

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -33 lines) Patch
M chrome/renderer/command_buffer_proxy.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/command_buffer_proxy.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/common/command_buffer.h View 1 2 3 2 chunks +1 line, -13 lines 0 comments Download
M gpu/command_buffer/common/command_buffer_mock.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/command_buffer_service.h View 1 2 3 2 chunks +12 lines, -1 line 0 comments Download
M gpu/command_buffer/service/command_buffer_service.cc View 3 2 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gpu_processor.h View 2 3 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/pepper_test_plugin/command_buffer_pepper.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/pepper_test_plugin/command_buffer_pepper.cc View 1 2 3 2 chunks +1 line, -6 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Alok Priyadarshi
5 years, 4 months ago (2010-01-07 05:45:03 UTC) #1
apatrick_chromium
LGTM http://codereview.chromium.org/527009/diff/4001/4004 File gpu/command_buffer/service/command_buffer_service.h (right): http://codereview.chromium.org/527009/diff/4001/4004#newcode45 gpu/command_buffer/service/command_buffer_service.h:45: virtual void SetPutOffsetChangeCallback(Callback0::Type* callback); Can you move this ...
5 years, 4 months ago (2010-01-08 18:54:04 UTC) #2
Alok Priyadarshi
5 years, 4 months ago (2010-01-08 20:48:14 UTC) #3
Also changed the order of function definitions in cc file.

http://codereview.chromium.org/527009/diff/4001/4004
File gpu/command_buffer/service/command_buffer_service.h (right):

http://codereview.chromium.org/527009/diff/4001/4004#newcode45
gpu/command_buffer/service/command_buffer_service.h:45: virtual void
SetPutOffsetChangeCallback(Callback0::Type* callback);
On 2010/01/08 18:54:04, apatrick_chromium wrote:
> Can you move this out of the block of functions commented as being the
> implementation of the ComnandBuffer interface?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be