Chromium Code Reviews
Help | Chromium Project | Sign in
(698)

Issue 527005: wm: Make WM_MOVE_PANEL use top-right coordinates. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by Daniel Erat
Modified:
2 years, 11 months ago
Reviewers:
DaveMoore
CC:
chromium-os-reviews_googlegroups.com
Visibility:
Public.

Description

wm: Make WM_MOVE_PANEL use top-right coordinates.

It was poorly documented in the header, but this message
type previously expected Chrome to pass the window manager
the displaced coordinates of the top-left corner of the
panel's titlebar window. This doesn't work if it's possible
for the panel's titlebar window to get resized during the
drag, since the panel's titlebar is right-justified with the
content window. I plan to make us resize the titlebar mid-
drag soon to support docking panels on the sides of the
screen.

This change makes the window manager expect the message to
contain the displaced coordinates of the top-right corner of
the titlebar window instead. (It's technically one pixel to
the right of the corner -- see wm_ipc.h for details.) It'll
require a corresponding change in Chrome.

It also adds (crude) versioning for WM/Chrome IP messages,
so this change should still work with existing Chrome builds.

Patch Set 1 #

Patch Set 2 : rename WM_MOVE_PANEL to WM_NOTIFY_PANEL_DRAGGED #

Patch Set 3 : add versioning to wmipc protocl #

Patch Set 4 : update comment #

Patch Set 5 : fix a poorly-worded sentence #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -18 lines) Lint Patch
M src/platform/window_manager/mock_chrome.h View 1 chunk +2 lines, -2 lines 0 comments 0 errors Download
M src/platform/window_manager/mock_chrome.cc View 1 2 3 chunks +8 lines, -2 lines 0 comments 0 errors Download
M src/platform/window_manager/panel_bar.cc View 1 2 3 chunks +10 lines, -5 lines 0 comments 0 errors Download
M src/platform/window_manager/window_manager.h View 2 chunks +6 lines, -0 lines 0 comments 0 errors Download
M src/platform/window_manager/window_manager.cc View 2 chunks +8 lines, -1 line 0 comments 0 errors Download
M src/platform/window_manager/window_manager_test.cc View 1 chunk +19 lines, -0 lines 0 comments 0 errors Download
M src/platform/window_manager/wm_ipc.h View 1 2 3 4 4 chunks +45 lines, -8 lines 0 comments 2 errors Download
Trybot results:
Commit:

Messages

Total messages: 3
Daniel Erat
4 years, 3 months ago #1
DaveMoore
LGTM. I guess it's ok to just time the checkins so that we're not broken ...
4 years, 3 months ago #2
DaveMoore
4 years, 3 months ago #3
LGTM. Thanks for making the WM compatible w/ existing Chrome.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6