Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 527003002: Improve text inputs focusing behaviour (Closed)

Created:
6 years, 3 months ago by atsykhonia
Modified:
6 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Improve text inputs focusing behaviour 1. save page scale factor if it is greater than minimal legible/readable scale 2. normalize sizeRect on current page scale factor to be measurable with caret and textboxRect R=aelias@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181508

Patch Set 1 #

Patch Set 2 : Added test to WebFrameTest #

Patch Set 3 : Fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
M Source/web/WebViewImpl.cpp View 1 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 2 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
atsykhonia
6 years, 3 months ago (2014-09-01 08:31:21 UTC) #1
aelias_OOO_until_Jul13
These changes look fine, good catch on the coordinate space bug. Could you add two ...
6 years, 3 months ago (2014-09-03 19:50:13 UTC) #2
atsykhonia
On 2014/09/03 19:50:13, aelias wrote: > These changes look fine, good catch on the coordinate ...
6 years, 3 months ago (2014-09-05 16:12:40 UTC) #3
aelias_OOO_until_Jul13
lgtm
6 years, 3 months ago (2014-09-05 18:36:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atsykhonia@yandex-team.ru/527003002/20001
6 years, 3 months ago (2014-09-06 10:11:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/18569)
6 years, 3 months ago (2014-09-06 10:23:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atsykhonia@yandex-team.ru/527003002/40001
6 years, 3 months ago (2014-09-06 12:43:21 UTC) #10
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 14:44:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atsykhonia@yandex-team.ru/527003002/40001
6 years, 3 months ago (2014-09-06 18:39:19 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-07 08:25:40 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 181508

Powered by Google App Engine
This is Rietveld 408576698