Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 52693003: Speculative Android build fix. (Closed)

Created:
7 years, 1 month ago by Stephen White
Modified:
7 years, 1 month ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Speculative Android build fix. TBR=robertphillips Committed: https://code.google.com/p/skia/source/detail?r=12041

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gyp/opts.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Stephen White
Committed patchset #1 manually as r12041 (presubmit successful).
7 years, 1 month ago (2013-10-30 22:38:19 UTC) #1
robertphillips
lgtm
7 years, 1 month ago (2013-10-30 22:48:00 UTC) #2
Tom Hudson
Not LGTM?! This gyp change has rolled into Chrome for Android, but SkMorphology_opts_none.cpp hasn't!
7 years, 1 month ago (2013-11-01 11:25:26 UTC) #3
robertphillips
This is the Skia-side opts change. I believe the problematic one is in the DEPS ...
7 years, 1 month ago (2013-11-01 12:03:24 UTC) #4
Stephen White
Are there failing bots somewhere?This change went into Skia, and I made sure that the ...
7 years, 1 month ago (2013-11-01 12:25:01 UTC) #5
Tom Hudson
It looks like somehow my repository was in an inconsistent state. Not sure what caused ...
7 years, 1 month ago (2013-11-01 12:30:09 UTC) #6
Stephen White
7 years, 1 month ago (2013-11-01 12:51:07 UTC) #7
Message was sent while issue was closed.
On 2013/11/01 12:30:09, Tom Hudson wrote:
> It looks like somehow my repository was in an inconsistent state. Not sure
what
> caused that, but I'm building now. Sorry for raising the red flag.

No problem! Glad it all worked out.

Powered by Google App Engine
This is Rietveld 408576698