Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 526863002: remoting: Suppress a clang warning that fires in atl headers. (Closed)

Created:
6 years, 3 months ago by Nico
Modified:
6 years, 3 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

remoting: Suppress a clang warning that fires in atl headers. Suppresses In file included from ..\..\remoting/host/verify_config_window_win.h:10: ..\..\third_party\wtl\include\atlapp.h(1683,17) : warning(clang): using namespace directive in global context in header [-Wheader-hygiene] using namespace WTL; ^ BUG=5027, 82385 TBR=jamiewalch@chromium.org Committed: https://crrev.com/f49fcfbf0db909f48d245f06240f184d473ec55d Cr-Commit-Position: refs/heads/master@{#292821}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M remoting/remoting_host_win.gypi View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Nico
It looks like there are only 7 files that include ATL in remoting. Do you ...
6 years, 3 months ago (2014-08-31 20:24:30 UTC) #2
Nico
Committed patchset #1 (id:1) manually as f49fcfb (presubmit successful).
6 years, 3 months ago (2014-08-31 20:58:52 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:15:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f49fcfbf0db909f48d245f06240f184d473ec55d
Cr-Commit-Position: refs/heads/master@{#292821}

Powered by Google App Engine
This is Rietveld 408576698