Replace init_cb in Renderer::Initialize() with base::Closure.

Replace init_cb in Renderer::Initialize() with base::Closure.

BUG=392236
TEST=Existing tests pass.

Committed: https://crrev.com/3dd339ddb7068045d29b0ce7edf539dd96e4fd85
Cr-Commit-Position: refs/heads/master@{#293048}

[xhwang, 2014-08-30 04:39:30]

xhwang@chromium.org changed reviewers:
+ scherkus@chromium.org

[xhwang, 2014-08-30 04:39:31]

Here's another clean-up CL. PTAL

[scherkus (not reviewing), 2014-09-02 20:12:49]

lgtm

[xhwang, 2014-09-02 22:41:28]

rebase only

[xhwang, 2014-09-02 22:41:38]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2014-09-02 22:42:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xhwang@chromium.org/526653002/20001

[commit-bot: I haz the power, 2014-09-03 00:28:15]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-09-03 02:06:52]

Committed patchset #2 (id:20001) as 7d4bbcb0b64d84d4881cf96eb32952a75ec4baa0

[tim (not reviewing), 2014-09-03 22:37:26]

tim@chromium.org changed reviewers:
+ tim@chromium.org

[tim (not reviewing), 2014-09-03 22:37:27]

https://codereview.chromium.org/526653002/diff/20001/media/base/renderer.h
File media/base/renderer.h (right):

https://codereview.chromium.org/526653002/diff/20001/media/base/renderer.h#ne...
media/base/renderer.h:36: virtual void Initialize(const base::Closure& init_cb,
How important is it to return PIPELINE_ERROR_INITIALIZATION_FAILED if init
fails? e.g, In a case like I have at https://codereview.chromium.org/518163003,
it was easy before this CL to return that error code without having to add extra
state to my RendererImpl.

[xhwang, 2014-09-03 23:52:37]

https://codereview.chromium.org/526653002/diff/20001/media/base/renderer.h
File media/base/renderer.h (right):

https://codereview.chromium.org/526653002/diff/20001/media/base/renderer.h#ne...
media/base/renderer.h:36: virtual void Initialize(const base::Closure& init_cb,
On 2014/09/03 22:37:26, timsteele wrote:
> How important is it to return PIPELINE_ERROR_INITIALIZATION_FAILED if init
> fails? e.g, In a case like I have at
https://codereview.chromium.org/518163003,
> it was easy before this CL to return that error code without having to add
extra
> state to my RendererImpl.

I don't quite follow the question.

In you CL, you'll need to plumb in the error_cb_ to your remote_renderer_ (for
other failure cases, e.g. flush error, decoding error). Then you can basically
follow the same model: when init fails, call error_cb first, then fire the
completion callback.

Does that answer your question?

[commit-bot: I haz the power, 2014-09-10 03:22:48]

Patchset 2 (id:??) landed as
https://crrev.com/3dd339ddb7068045d29b0ce7edf539dd96e4fd85
Cr-Commit-Position: refs/heads/master@{#293048}