Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1832)

Unified Diff: Tools/GardeningServer/model/test/ct-failure-tests.html

Issue 526633002: Apply object updates from the network without blowing away object identity or UI attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Initial Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/model/test/ct-failure-tests.html
diff --git a/Tools/GardeningServer/model/test/ct-failure-tests.html b/Tools/GardeningServer/model/test/ct-failure-tests.html
index 7bdffc3486a9de546436a1a41ef3f92d1ee85091..3d6c12e8d9cc16db58b96021db96fedae23bfa0e 100644
--- a/Tools/GardeningServer/model/test/ct-failure-tests.html
+++ b/Tools/GardeningServer/model/test/ct-failure-tests.html
@@ -15,15 +15,18 @@ describe('ct-failure model', function() {
var tests = [
{
failure: new CTFailure('browser_tests', 'FooTest.Bar', {}, 123, 123),
- expectedGroupName: 'FooTest'
+ expectedGroupName: 'FooTest',
+ expectedFingerprint: 'browser_tests::FooTest.Bar',
},
{
failure: new CTFailure('webkit_tests', 'fast/text/foo.html', {}, 123, 123),
- expectedGroupName: 'fast/text'
+ expectedGroupName: 'fast/text',
+ expectedFingerprint: 'webkit_tests::fast/text/foo.html',
},
{
failure: new CTFailure('compile', undefined, {}, 123, 123),
- expectedGroupName: undefined
+ expectedGroupName: undefined,
+ expectedFingerprint: 'compile::undefined',
}
];
it('group name', function() {
@@ -31,6 +34,11 @@ describe('ct-failure model', function() {
assert.equal(test.failure.reasonGroupName(), test.expectedGroupName);
});
});
+ it('has fingerprint', function() {
+ tests.forEach(function(test) {
+ assert.propertyVal(test.failure, 'fingerprint', test.expectedFingerprint);
+ });
+ });
});
})();

Powered by Google App Engine
This is Rietveld 408576698