Tools/GardeningServer/model/ct-failure.html - Issue 526633002: Apply object updates from the network without blowing away object identity or UI attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/GardeningServer/model/ct-failure.html

Issue 526633002: Apply object updates from the network without blowing away object identity or UI attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Simplify and document updateLeft() using the fact that it returns the resulting object. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Tools/GardeningServer/model/ct-failure.html

diff --git a/Tools/GardeningServer/model/ct-failure.html b/Tools/GardeningServer/model/ct-failure.html

index 73ac640be64a96e7e45efab09c13153cf3301eb2..30576156a7eed48aaab8c5236db8951d2f7f14a2 100644

--- a/Tools/GardeningServer/model/ct-failure.html

+++ b/Tools/GardeningServer/model/ct-failure.html

@@ -6,9 +6,12 @@ found in the LICENSE file.

function CTFailure(step, reason, resultsByBuilder) {

+ this.key = step + '::' + reason;

this.step = step;

// FIXME: Rename this to reason.

this.testName = reason;

+ // Maps a builder_name (e.g. "Mac ASan Tests (1)")

+ // to the details of the failure on that builder.

this.resultNodesByBuilder = resultsByBuilder;

}

« no previous file with comments | « Tools/GardeningServer/model/ct-commit-list.html ('k') | Tools/GardeningServer/model/ct-failure-group.html » ('j') | no next file with comments »