Apply object updates from the network without blowing away object identity or UI attributes.

Tools/GardeningServer/model/ct-failures.html

 <!--
 Copyright 2014 The Chromium Authors. All rights reserved.
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
 <link rel="import" href="../lib/net.html">
+<link rel="import" href="../lib/update-util.html">
 <link rel="import" href="ct-builder-revisions.html">
 <link rel="import" href="ct-failure.html">
 <link rel="import" href="ct-failure-group.html">
 <link rel="import" href="ct-commit-list.html">
 
 <script>
 function CTFailures(commitLog) {
   this.commitLog = commitLog;
   this.builderLatestRevisions = null;
-  this.failures = null;
+  // Maps a tree id to an array of CTFailureGroups within that tree.
+  this.failures = {};
   this.lastUpdateDate = null;
 
   // FIXME: Get this from
   // https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave/gatekeeper_trees.json?format=text.
   this._trees = {
     blink: [
       "https://build.chromium.org/p/chromium.webkit",
     ],
     chromium: [
       "https://build.chromium.org/p/chromium",
@@ skipping 42 matching lines @@
       return -1;
 
     if (a_list.last() != b_list.last())
       return b_list.last() - a_list.last();
   }
   return 0;
 };
 
 CTFailures.prototype.update = function() {
   var annotationPromise = CTFailureGroup.fetchAnnotations();
-  net.json('http://sheriff-o-matic.appspot.com/alerts').then(function(data) {
-    annotationPromise.then(function(annotations) {
+
+  return net.json('http://sheriff-o-matic.appspot.com/alerts').then(function(data) {
+    return annotationPromise.then(function(annotations) {
       // FIXME: Don't special-case the blink master.
       this.builderLatestRevisions = new CTBuilderRevisions(data.latest_builder_info['chromium.webkit']);
-      this.failures = {};
+      var newFailures = {};
       this.lastUpdateDate = new Date(data.date * 1000);
       // Update |failures| with the appropriate CTFailureGroup's for each
       // tree.
       data.range_groups.forEach(function(rangeGroup) {
-        this._processFailuresForRangeGroup(rangeGroup, data.alerts, annotations);
+        this._processFailuresForRangeGroup(newFailures, rangeGroup, data.alerts, annotations);
       }.bind(this));
       // Sort failure groups so that newer failures are shown at the top
       // of the UI.
-      Object.keys(this.failures, function (tree, failuresByTree) {
-        this.failures[tree].sort(this._failureByTreeListComparator.bind(this, tree));
+      Object.keys(newFailures, function (tree, failuresByTree) {
+        failuresByTree.sort(this._failureByTreeListComparator.bind(this, tree));
       }.bind(this));
+      this.failures = updateUtil.updateLeft(this.failures, newFailures);
     }.bind(this));
   }.bind(this));
 };
 
 CTFailures.prototype._failureComparator = function(a, b) {
   if (a.step > b.step)
     return 1;
   if (a.step < b.step)
     return -1
   if (a.testName > b.testName)
     return 1;
   if (a.testName < b.testName)
     return -1
   return 0;
 };
 
-CTFailures.prototype._processFailuresForRangeGroup = function(rangeGroup, alerts, annotations) {
+CTFailures.prototype._processFailuresForRangeGroup = function(newFailures, rangeGroup, alerts, annotations) {
   var masterToTree = {};
   Object.keys(this._trees, function(tree, masters) {
     masters.forEach(function(master) {
       masterToTree[master] = tree;
     });
   });
 
   // A rangeGroup may be related to multiple alerts (via |failure_keys|). Categorize
   // these failures by reason (cause of failure), so that they can be grouped in the UI
   // (via a CTFailureGroup). Failures will be grouped in |failuresByReason|.
@@ skipping 36 matching lines @@
       earliestFailingBuild: failure.failing_build,
       masterUrl: failure.master_url,
       failingBuildCount: failure.failing_build_count,
       annotation: annotations[failureKey],
     };
   }.bind(this));
 
   if (!Object.keys(failuresByReason).length)
     return;
 
+  // Maps a tree id to a list of CTFailures in that tree.
   var groupedFailures = {};
   Object.keys(failuresByReason, function(reasonKey, resultsByTree) {
     var failure = JSON.parse(reasonKey);
     Object.keys(resultsByTree, function(tree, resultsByBuilder) {
       if (!groupedFailures[tree])
         groupedFailures[tree] = [];
       groupedFailures[tree].push(
           new CTFailure(failure.step, failure.reason, resultsByBuilder));
     })
   });
 
   Object.keys(groupedFailures, function(tree, failures) {
     failures.sort(this._failureComparator);
 
-    if (!this.failures[tree])
-      this.failures[tree] = [];
+    if (!newFailures[tree])
+      newFailures[tree] = [];
     var commitList = new CTCommitList(this.commitLog, rangeGroup.likely_revisions);
-    this.failures[tree].push(new CTFailureGroup(failures, commitList));
+    newFailures[tree].push(new CTFailureGroup(rangeGroup.sort_key, failures, commitList));
   }.bind(this));
 };
 
 </script>