Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 526593003: Move tools/usb_gadget.gyp to tools/usb_gadget/usb_gadget.gyp. (Closed)

Created:
6 years, 3 months ago by Reilly Grant (use Gerrit)
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move tools/usb_gadget.gyp to tools/usb_gadget/usb_gadget.gyp. This placement more closely matches the GN layout. BUG=None R=rockot@chromium.org,tfarina@chromium.org Committed: https://crrev.com/4e279527936c87f440663b15dd29a71771ac36a9 Cr-Commit-Position: refs/heads/master@{#293622}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed indentation. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -76 lines) Patch
M device/device_tests.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
D tools/usb_gadget.gyp View 1 2 1 chunk +0 lines, -52 lines 0 comments Download
A + tools/usb_gadget/usb_gadget.gyp View 1 2 2 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Reilly Grant (use Gerrit)
This change was suggested by tfarina as an after-the-fact comment on https://codereview.chromium.org/414833004/.
6 years, 3 months ago (2014-08-30 01:08:12 UTC) #2
tfarina
https://codereview.chromium.org/526593003/diff/1/tools/usb_gadget/usb_gadget.gyp File tools/usb_gadget/usb_gadget.gyp (right): https://codereview.chromium.org/526593003/diff/1/tools/usb_gadget/usb_gadget.gyp#newcode1 tools/usb_gadget/usb_gadget.gyp:1: # Copyright 2014 The Chromium Authors. All rights reserved. ...
6 years, 3 months ago (2014-08-30 02:10:27 UTC) #3
Reilly Grant (use Gerrit)
https://codereview.chromium.org/526593003/diff/1/tools/usb_gadget/usb_gadget.gyp File tools/usb_gadget/usb_gadget.gyp (right): https://codereview.chromium.org/526593003/diff/1/tools/usb_gadget/usb_gadget.gyp#newcode1 tools/usb_gadget/usb_gadget.gyp:1: # Copyright 2014 The Chromium Authors. All rights reserved. ...
6 years, 3 months ago (2014-08-31 16:54:22 UTC) #4
tfarina
cool, patch set 2 lgtm.
6 years, 3 months ago (2014-08-31 17:58:37 UTC) #5
Ken Rockot(use gerrit already)
lgtm
6 years, 3 months ago (2014-09-04 01:59:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reillyg@chromium.org/526593003/40001
6 years, 3 months ago (2014-09-05 19:34:35 UTC) #8
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 01:36:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reillyg@chromium.org/526593003/40001
6 years, 3 months ago (2014-09-06 17:05:20 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as bc31a02d43e045415047a7a9b93e01fc5f8dedaa
6 years, 3 months ago (2014-09-06 18:38:05 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:42:52 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4e279527936c87f440663b15dd29a71771ac36a9
Cr-Commit-Position: refs/heads/master@{#293622}

Powered by Google App Engine
This is Rietveld 408576698