Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: git_cl.py

Issue 526523002: Use full hash in Committed link when closing issue via git-cl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 7793c8cb0644a1e3d09e2f457bbdc25f94f788bc..c8d0ae03bb4873318297c3f0b544f979fdb42e22 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -2055,11 +2055,10 @@ def SendUpstream(parser, args, cmd):
DieWithError(
"Couldn't parse ouput to extract the committed hash:\n%s" % output)
revision = match[0].group(2)
agable 2014/08/29 22:20:36 Why keep this old parsing logic around at all and
+ revision = RunGit(['rev-parse', revision]).strip()
else:
return 1
- revision = revision[:7]
-
to_pending = ' to pending queue' if pushed_to_pending else ''
viewvc_url = settings.GetViewVCUrl()
if not to_pending:
@@ -2075,7 +2074,7 @@ def SendUpstream(parser, args, cmd):
props = cl.GetIssueProperties()
patch_num = len(props['patchsets'])
comment = "Committed patchset #%d (id:%d)%s manually as %s" % (
- patch_num, props['patchsets'][-1], to_pending, revision)
+ patch_num, props['patchsets'][-1], to_pending, revision[:7])
if options.bypass_hooks:
comment += ' (tree was closed).' if GetTreeStatus() == 'closed' else '.'
else:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698