Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 526523002: Use full hash in Committed link when closing issue via git-cl. (Closed)

Created:
6 years, 3 months ago by iannucci
Modified:
6 years, 3 months ago
Reviewers:
Vadim Sh., agable
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Project:
tools
Visibility:
Public.

Description

Use full hash in Committed link when closing issue via git-cl. R=agable@chromium.org, vadimsh@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291751

Patch Set 1 #

Total comments: 1

Patch Set 2 : cleanup revision parsing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -25 lines) Patch
M git_cl.py View 1 4 chunks +12 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
iannucci
6 years, 3 months ago (2014-08-29 22:16:23 UTC) #1
agable
https://codereview.chromium.org/526523002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/526523002/diff/1/git_cl.py#newcode2057 git_cl.py:2057: revision = match[0].group(2) Why keep this old parsing logic ...
6 years, 3 months ago (2014-08-29 22:20:37 UTC) #2
agable
On 2014/08/29 22:20:37, agable wrote: > https://codereview.chromium.org/526523002/diff/1/git_cl.py > File git_cl.py (right): > > https://codereview.chromium.org/526523002/diff/1/git_cl.py#newcode2057 > ...
6 years, 3 months ago (2014-08-29 23:43:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/526523002/20001
6 years, 3 months ago (2014-08-29 23:49:55 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-08-29 23:51:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 291751

Powered by Google App Engine
This is Rietveld 408576698