clang/win: Fix a few warnings in targets not in chromium_builder_tests.

Committed: https://crrev.com/d85710844c00acbfcf95f84ebcb6012d72eac645
Cr-Commit-Position: refs/heads/master@{#292699}

[Nico, 2014-08-29 21:54:18]

thakis@chromium.org changed reviewers:
+ hans@chromium.org

[hans, 2014-08-29 21:55:08]

lgtm

[Nico, 2014-08-29 22:17:02]

thakis@chromium.org changed reviewers:
+ gab@chromium.org, robertshield@chromium.org

[Nico, 2014-08-29 22:17:02]

I've added some more stuff, ptal. Now fixes a real bug too.

[hans, 2014-08-29 22:35:45]

lgtm 2

i guess the bug was the missing .c_str() ?

[Nico, 2014-08-29 22:35:45]

thakis@chromium.org changed reviewers:
+ cpu@chromium.org, vitalybuka@chromium.org

[Nico, 2014-08-29 22:35:46]

tbr vitalybuka for cloud_print/owners, cpu for sandbox/win/owners

[Nico, 2014-08-29 22:36:23]

On Fri, Aug 29, 2014 at 3:35 PM, <hans@chromium.org> wrote:

> lgtm 2
>
> i guess the bug was the missing .c_str() ?
>

Yup.


>
> https://codereview.chromium.org/526513002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-08-29 22:43:09]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-08-29 22:43:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thakis@chromium.org/526513002/40001

[Nico, 2014-08-29 22:46:29]

Committed patchset #3 to pending queue manually as d7efa09 (presubmit
successful).

[Vitaly Buka (NO REVIEWS), 2014-08-30 19:44:38]

lgtm

[Nico, 2014-08-30 23:43:04]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/519463003/ by thakis@chromium.org.

The reason for reverting is: Speculative, might have broken
InstallerStateTest.InitializeTwice on XP:
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds...

InstallerStateTest.InitializeTwice (run #1):
[ RUN      ] InstallerStateTest.InitializeTwice
c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639):
error: Value of: wcsstr(installer_state.target_path().value().c_str(),
BrowserDistribution::GetSpecificDistribution(
BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
  Actual: false
Expected: true
[  FAILED  ] InstallerStateTest.InitializeTwice (219 ms)

InstallerStateTest.InitializeTwice (run #2):
[ RUN      ] InstallerStateTest.InitializeTwice
c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639):
error: Value of: wcsstr(installer_state.target_path().value().c_str(),
BrowserDistribution::GetSpecificDistribution(
BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
  Actual: false
Expected: true
[  FAILED  ] InstallerStateTest.InitializeTwice (109 ms)
.

[gab, 2014-09-02 18:47:12]

installer/gcapi lgtm

[commit-bot: I haz the power, 2014-09-10 03:11:04]

Patchset 3 (id:??) landed as
https://crrev.com/d85710844c00acbfcf95f84ebcb6012d72eac645
Cr-Commit-Position: refs/heads/master@{#292699}