Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 526503002: SetUploadData now throws an exception if contentType is null. (Closed)

Created:
6 years, 3 months ago by mef
Modified:
6 years, 3 months ago
Reviewers:
Charles, mmenke, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

SetUploadData now throws an exception if contentType is null. It used to crash in nativeSetUploadData instead. BUG=409151 Committed: https://crrev.com/b459f829122c050a2c711099cc76610170edc5ab Cr-Commit-Position: refs/heads/master@{#292729}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java View 4 chunks +9 lines, -0 lines 0 comments Download
M components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java View 1 2 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
mef
6 years, 3 months ago (2014-08-29 20:30:54 UTC) #2
mmenke
On 2014/08/29 20:30:54, mef wrote: LGTM
6 years, 3 months ago (2014-08-29 20:34:05 UTC) #3
xunjieli
lgtm. Thanks for keeping me in the loop. https://codereview.chromium.org/526503002/diff/1/components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java File components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java (right): https://codereview.chromium.org/526503002/diff/1/components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java#newcode156 components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java:156: // ...
6 years, 3 months ago (2014-08-29 20:41:18 UTC) #4
mef
thanks! https://codereview.chromium.org/526503002/diff/1/components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java File components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java (right): https://codereview.chromium.org/526503002/diff/1/components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java#newcode156 components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java:156: // Create request with null listener to trigger ...
6 years, 3 months ago (2014-08-29 20:46:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 199613305f2f5146ed1a9390a225d269b69fdddd
6 years, 3 months ago (2014-08-30 00:14:38 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:12:11 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b459f829122c050a2c711099cc76610170edc5ab
Cr-Commit-Position: refs/heads/master@{#292729}

Powered by Google App Engine
This is Rietveld 408576698