Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 526493004: Revert of Keep a copy of page id in RenderViewHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 899 matching lines...) Expand 10 before | Expand all | Expand 10 after
910 // TODO(nasko): Move to RenderFrame, as this is per-frame state. 910 // TODO(nasko): Move to RenderFrame, as this is per-frame state.
911 scoped_ptr<FrameMsg_Navigate_Params> pending_navigation_params_; 911 scoped_ptr<FrameMsg_Navigate_Params> pending_navigation_params_;
912 912
913 // Timer used to delay the updating of nav state (see SyncNavigationState). 913 // Timer used to delay the updating of nav state (see SyncNavigationState).
914 base::OneShotTimer<RenderViewImpl> nav_state_sync_timer_; 914 base::OneShotTimer<RenderViewImpl> nav_state_sync_timer_;
915 915
916 // Page IDs ------------------------------------------------------------------ 916 // Page IDs ------------------------------------------------------------------
917 // See documentation in RenderView. 917 // See documentation in RenderView.
918 int32 page_id_; 918 int32 page_id_;
919 919
920 // TEMPORARY <http://crbug.com/407376>. If true, then |page_id_| has been
921 // changed but not yet reported to the browser process. No IPCs should be sent
922 // with a page_id_ while this is true.
923 bool page_id_not_yet_reported_;
924
925 // Indicates the ID of the last page that we sent a FrameNavigate to the 920 // Indicates the ID of the last page that we sent a FrameNavigate to the
926 // browser for. This is used to determine if the most recent transition 921 // browser for. This is used to determine if the most recent transition
927 // generated a history entry (less than page_id_), or not (equal to or 922 // generated a history entry (less than page_id_), or not (equal to or
928 // greater than). Note that this will be greater than page_id_ if the user 923 // greater than). Note that this will be greater than page_id_ if the user
929 // goes back. 924 // goes back.
930 int32 last_page_id_sent_to_browser_; 925 int32 last_page_id_sent_to_browser_;
931 926
932 // The next available page ID to use for this RenderView. These IDs are 927 // The next available page ID to use for this RenderView. These IDs are
933 // specific to a given RenderView and the frames within it. 928 // specific to a given RenderView and the frames within it.
934 int32 next_page_id_; 929 int32 next_page_id_;
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
1133 // use the Observer interface to filter IPC messages and receive frame change 1128 // use the Observer interface to filter IPC messages and receive frame change
1134 // notifications. 1129 // notifications.
1135 // --------------------------------------------------------------------------- 1130 // ---------------------------------------------------------------------------
1136 1131
1137 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 1132 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
1138 }; 1133 };
1139 1134
1140 } // namespace content 1135 } // namespace content
1141 1136
1142 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 1137 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698