Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 526493004: Revert of Keep a copy of page id in RenderViewHost. (Closed)

Created:
6 years, 3 months ago by Charlie Reis
Modified:
6 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Keep a copy of page id in RenderViewHost. (patchset #2 id:20001 of https://codereview.chromium.org/517813002/) Reason for revert: Crash data is coming in from the 39.0.2140.0 canary. I'll revert this so that it doesn't continue reporting crashes over the long weekend. (Sadly, the crashes so far appear to be in the browser process and not the renderer process, meaning we don't have a solid explanation yet.) Original issue's description: > Keep a copy of page id in RenderViewHost. > > This is an instrumented version of the patch that will be reverted in a few days. This is meant to catch crashes in edge cases and log enough for us to repro them. > > BUG=407376 > TEST=this may crash for a few people > > Committed: https://chromium.googlesource.com/chromium/src/+/ab752e59a10a2a4c322ee7f6dbbb16a4fdb467e0 TBR=avi@chromium.org NOTREECHECKS=true NOTRY=true BUG=407376 Committed: https://crrev.com/174373bc5289c2c644e1343a348a2499fa64c6c4 Cr-Commit-Position: refs/heads/master@{#292727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -38 lines) Patch
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 4 chunks +2 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_view_host_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 5 chunks +0 lines, -5 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_view_impl.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_render_view_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Charlie Reis
Created Revert of Keep a copy of page id in RenderViewHost.
6 years, 3 months ago (2014-08-29 23:54:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/526493004/1
6 years, 3 months ago (2014-08-29 23:57:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as c02f0dbcb26cbb990a6486be77b6f23c45b5e3fe
6 years, 3 months ago (2014-08-30 00:06:58 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:12:07 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/174373bc5289c2c644e1343a348a2499fa64c6c4
Cr-Commit-Position: refs/heads/master@{#292727}

Powered by Google App Engine
This is Rietveld 408576698