Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 526313002: [turbofan] First step of Operator refactoring. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] First step of Operator refactoring. - Real const-correctness - Proper forward declarations instead of #include "src/v8.h" - Flags for Operator properties. - etc. TEST=compiler-unittests,cctest R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23601

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+375 lines, -302 lines) Patch
M BUILD.gn View 1 3 chunks +3 lines, -0 lines 0 comments Download
M src/base/flags.h View 1 chunk +17 lines, -30 lines 0 comments Download
M src/compiler/access-builder.h View 1 chunk +10 lines, -54 lines 0 comments Download
A src/compiler/access-builder.cc View 1 chunk +90 lines, -0 lines 0 comments Download
M src/compiler/arm/linkage-arm.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
M src/compiler/arm64/linkage-arm64.cc View 1 2 chunks +6 lines, -7 lines 0 comments Download
M src/compiler/common-operator.h View 3 chunks +9 lines, -6 lines 0 comments Download
M src/compiler/ia32/linkage-ia32.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/linkage.h View 1 4 chunks +9 lines, -9 lines 0 comments Download
M src/compiler/linkage.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M src/compiler/linkage-impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/operator.h View 5 chunks +63 lines, -67 lines 0 comments Download
A src/compiler/operator.cc View 1 chunk +56 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 3 chunks +12 lines, -60 lines 0 comments Download
A src/compiler/simplified-operator.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M src/compiler/x64/linkage-x64.cc View 1 2 chunks +6 lines, -7 lines 0 comments Download
M test/cctest/compiler/test-operator.cc View 10 chunks +43 lines, -43 lines 0 comments Download
M tools/gyp/v8.gyp View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 3 months ago (2014-09-02 11:22:39 UTC) #2
Sven Panne
lgtm
6 years, 3 months ago (2014-09-02 11:33:21 UTC) #3
Benedikt Meurer
6 years, 3 months ago (2014-09-02 11:37:15 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 23601 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698