Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 526303003: mojo: java bindings rename Message subclasses. (Closed)

Created:
6 years, 3 months ago by qsr
Modified:
6 years, 3 months ago
Reviewers:
ppi
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: java bindings rename Message subclasses. R=ppi@chromium.org Committed: https://crrev.com/ed0e64147d4360328799c153ac069a5f46e7daae Cr-Commit-Position: refs/heads/master@{#293485}

Patch Set 1 #

Patch Set 2 : Follow review #

Patch Set 3 : Refactoru inheritance. #

Patch Set 4 : Refactor inheritance #

Total comments: 4

Patch Set 5 : Follow review #

Patch Set 6 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -227 lines) Patch
M mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTestUtils.java View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/bindings/ConnectorTest.java View 1 chunk +1 line, -1 line 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/bindings/MessageHeaderTest.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/bindings/ReadAndDispatchMessageTest.java View 1 chunk +1 line, -1 line 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/bindings/RouterTest.java View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/bindings/ValidationTest.java View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/java/BUILD.gn View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/Connector.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/Encoder.java View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/Message.java View 1 2 3 4 1 chunk +43 lines, -9 lines 0 comments Download
D mojo/public/java/bindings/src/org/chromium/mojo/bindings/MessageWithHeader.java View 1 chunk +0 lines, -93 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/RouterImpl.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + mojo/public/java/bindings/src/org/chromium/mojo/bindings/ServiceMessage.java View 1 2 5 chunks +10 lines, -30 lines 0 comments Download
D mojo/public/java/bindings/src/org/chromium/mojo/bindings/SimpleMessage.java View 1 chunk +0 lines, -71 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/Struct.java View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/java_templates/interface_definition.tmpl View 1 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
qsr
This is based on the validation test CL, so can only be pushed after.
6 years, 3 months ago (2014-09-02 15:29:07 UTC) #1
ppi
Following the discussion in person: let's explore moving from interface with two implementations, to base ...
6 years, 3 months ago (2014-09-03 08:56:15 UTC) #2
qsr
Change done.
6 years, 3 months ago (2014-09-03 10:53:50 UTC) #3
ppi
Looks great! Lgtm % nits. https://chromiumcodereview.appspot.com/526303003/diff/60001/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Message.java File mojo/public/java/bindings/src/org/chromium/mojo/bindings/Message.java (right): https://chromiumcodereview.appspot.com/526303003/diff/60001/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Message.java#newcode30 mojo/public/java/bindings/src/org/chromium/mojo/bindings/Message.java:30: * This message interpreted ...
6 years, 3 months ago (2014-09-03 11:44:08 UTC) #4
qsr
https://chromiumcodereview.appspot.com/526303003/diff/60001/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Message.java File mojo/public/java/bindings/src/org/chromium/mojo/bindings/Message.java (right): https://chromiumcodereview.appspot.com/526303003/diff/60001/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Message.java#newcode30 mojo/public/java/bindings/src/org/chromium/mojo/bindings/Message.java:30: * This message interpreted with headers. On 2014/09/03 11:44:08, ...
6 years, 3 months ago (2014-09-03 14:11:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/526303003/80001
6 years, 3 months ago (2014-09-04 09:16:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/526303003/80001
6 years, 3 months ago (2014-09-04 15:26:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/526303003/100001
6 years, 3 months ago (2014-09-04 15:28:29 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/53543) mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/43643)
6 years, 3 months ago (2014-09-04 16:20:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/526303003/100001
6 years, 3 months ago (2014-09-04 16:27:43 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/53568) mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/43720) win_gpu_triggered_tests ...
6 years, 3 months ago (2014-09-04 17:55:27 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/526303003/100001
6 years, 3 months ago (2014-09-05 08:19:25 UTC) #20
commit-bot: I haz the power
Committed patchset #6 (id:100001) as f4e4c7816a60927c9ab24b574c6eb0470ae6b9cb
6 years, 3 months ago (2014-09-05 09:56:15 UTC) #21
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:38:19 UTC) #22
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/ed0e64147d4360328799c153ac069a5f46e7daae
Cr-Commit-Position: refs/heads/master@{#293485}

Powered by Google App Engine
This is Rietveld 408576698