Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: tests/compiler/dart2js/backend_dart/dart_backend_test.dart

Issue 526263002: Remove unneeded generation of default constructors from the dart backend. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/backend_dart/dart_backend_test.dart
diff --git a/tests/compiler/dart2js/backend_dart/dart_backend_test.dart b/tests/compiler/dart2js/backend_dart/dart_backend_test.dart
index b92152f9ed10acc7270ebd9e2bd04ec5dfcde805..6746b917ecd0affb4433eb50c01cfc5046002e07 100644
--- a/tests/compiler/dart2js/backend_dart/dart_backend_test.dart
+++ b/tests/compiler/dart2js/backend_dart/dart_backend_test.dart
@@ -878,7 +878,24 @@ main() {
testDart2Dart(src, expectedResult: expectedResult);
}
-testUnresolvedNamedConstructor() {
+testUnresolvedNamedConstructor1() {
sigurdm 2014/09/02 09:14:06 Maybe it is nicer to keep the class alive with a s
+ var src = '''
+class A {
+}
+
+main() {
+ new A.named();
+}
+''';
+ var expectedResult = """
+main() {
+ new Unresolved();
+}
+""";
+ testDart2Dart(src, expectedResult: expectedResult);
+}
+
+testUnresolvedNamedConstructor2() {
var src = '''
class A {
A() {}
@@ -895,7 +912,7 @@ class A {
}
main() {
new A();
- new Unresolved_A();
+ new Unresolved();
}
""";
testDart2Dart(src, expectedResult: expectedResult);
@@ -929,5 +946,6 @@ main() {
testDeclarationTypePlaceholders();
testPlatformLibraryMemberNamesAreFixed();
testConflictsWithCoreLib();
- testUnresolvedNamedConstructor();
+ testUnresolvedNamedConstructor1();
+ testUnresolvedNamedConstructor2();
}
sigurdm 2014/09/02 09:14:06 Could also make a language-test (might already exi
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698