Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 526133003: Refactoring: Make gtest testsuite the default. (Closed)

Created:
6 years, 3 months ago by Michael Achenbach
Modified:
6 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Refactoring: Make gtest testsuite the default. BUG=v8:3489 R=bmeurer@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=23583

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -213 lines) Patch
D test/base-unittests/testcfg.py View 1 chunk +0 lines, -52 lines 0 comments Download
D test/compiler-unittests/testcfg.py View 1 chunk +0 lines, -52 lines 0 comments Download
D test/heap-unittests/testcfg.py View 1 chunk +0 lines, -52 lines 0 comments Download
D test/libplatform-unittests/testcfg.py View 1 chunk +0 lines, -52 lines 0 comments Download
M tools/testrunner/local/testsuite.py View 1 2 chunks +41 lines, -2 lines 0 comments Download
M tools/testrunner/local/utils.py View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Achenbach
PTAL
6 years, 3 months ago (2014-09-01 14:06:33 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/526133003/diff/40001/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/526133003/diff/40001/tools/run-tests.py#newcode430 tools/run-tests.py:430: os.path.join(workspace, "test", root), gtest_testsuite.GTestTestSuite) The GTestTestSuite should probably be ...
6 years, 3 months ago (2014-09-02 05:13:02 UTC) #3
Michael Achenbach
Done
6 years, 3 months ago (2014-09-02 06:37:50 UTC) #4
Benedikt Meurer
lgtm
6 years, 3 months ago (2014-09-02 08:22:10 UTC) #5
Michael Achenbach
6 years, 3 months ago (2014-09-02 09:11:26 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:80001) manually as 23583 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698