Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 526123002: Remove unused GeolocationDispatcher::geolocationDestroyed(). (Closed)

Created:
6 years, 3 months ago by sof
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove unused GeolocationDispatcher::geolocationDestroyed(). As of Blink r180944, Blink is no longer notifying the embedder of its GeolocationController reference going away (as there's no need.) Follow up and retire the notification implementation on the embedder side. R=mvanouwerkerk@chromium.org, jochen@chromium.org BUG= Committed: https://crrev.com/46343cfc3ce2ca18ccfed5da9df28c06d7437c6c Cr-Commit-Position: refs/heads/master@{#292890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M content/renderer/geolocation_dispatcher.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/geolocation_dispatcher.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sof
Please take a look.
6 years, 3 months ago (2014-09-01 13:02:51 UTC) #2
Michael van Ouwerkerk
lgtm
6 years, 3 months ago (2014-09-01 13:13:14 UTC) #3
sof
mvanouwerkerk@: thanks, looks like geolocation ownership isn't set up for you for this particular class. ...
6 years, 3 months ago (2014-09-01 13:27:27 UTC) #5
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-01 13:42:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/526123002/1
6 years, 3 months ago (2014-09-01 13:53:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 20daf37c655b59f34cd98406651d9f0819e4869b
6 years, 3 months ago (2014-09-01 19:20:12 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:17:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46343cfc3ce2ca18ccfed5da9df28c06d7437c6c
Cr-Commit-Position: refs/heads/master@{#292890}

Powered by Google App Engine
This is Rietveld 408576698