Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 526083002: [turbofan] Fix MachineOperatorReducer to use JSGraph as well. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix MachineOperatorReducer to use JSGraph as well. TEST=compiler-unittests,cctest R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23577

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -61 lines) Patch
M src/compiler/machine-operator-reducer.h View 3 chunks +19 lines, -15 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 10 chunks +27 lines, -34 lines 0 comments Download
M src/compiler/machine-operator-reducer-unittest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 1 13 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
6 years, 3 months ago (2014-09-01 10:50:20 UTC) #1
Benedikt Meurer
PTAL
6 years, 3 months ago (2014-09-01 10:51:42 UTC) #2
Jarin
lgtm
6 years, 3 months ago (2014-09-01 11:14:00 UTC) #3
Benedikt Meurer
6 years, 3 months ago (2014-09-02 05:09:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 23577 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698