Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 526063002: Change VKEY_MENU to VKEY_LMENU in interactive ui tests key sequence sending. (Closed)

Created:
6 years, 3 months ago by mharanczyk
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change VKEY_MENU to VKEY_LMENU in interactive ui tests key sequence sending. On windows depending on system/keyboard setting right alt (alt gr) can be seen as alt+ctrl. This is also true for sending VKEY_MENU via SendInput, probably because it is treated as any alt key. To avoid intorducing unwanted ctrl key in sequence use VKEY_LMENU which will only add alt key without a risk of adding ctrl key regardless of system setup. The change fixes CommandsApiTest.DontOverwriteSystemShortcuts test timout. Test expected alt+shift+f, but what was received was ctrl+alt+shift+f. BUG=409567 Committed: https://crrev.com/6047562c6cd816727b7a78a0def63cc30f0999a5 Cr-Commit-Position: refs/heads/master@{#293112}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/base/test/ui_controls_internal_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mharanczyk
PTAL.
6 years, 3 months ago (2014-09-01 09:12:54 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-09-02 17:34:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mharanczyk@opera.com/526063002/1
6 years, 3 months ago (2014-09-03 08:22:56 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-09-03 09:40:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as fd3cf72bd17dd7d46e999c1a45d8a24780c6c789
6 years, 3 months ago (2014-09-03 10:23:50 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:24:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6047562c6cd816727b7a78a0def63cc30f0999a5
Cr-Commit-Position: refs/heads/master@{#293112}

Powered by Google App Engine
This is Rietveld 408576698