src/opts/SkMorphology_opts.h - Issue 52603004: Implement SSE2-based implementations of the morphology filters (dilate &

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/opts/SkMorphology_opts.h

Issue 52603004: Implement SSE2-based implementations of the morphology filters (dilate & (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Fix typo in dilateY() Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 /*

	2 * Copyright 2013 The Android Open Source Project

	3 *

	4 * Use of this source code is governed by a BSD-style license that can be

	5 * found in the LICENSE file.

	6 */

	7

	8 #include <SkColor.h>

	9

	10 typedef void (SkMorphologyProc)(const SkPMColor src, SkPMColor* dst, int radiu s,

	11 int width, int height, int srcStride, int dstSt ride);
	reed1 2013/10/30 15:15:04 are these logically size_t? we use size_t for byte are these logically size_t? we use size_t for byte-offsets in general (e.g. rowBytes) mtklein 2013/10/30 15:44:47 These strides are pixel counts, so I think it make Show quoted text On 2013/10/30 15:15:04, reed1 wrote: > are these logically size_t? we use size_t for byte-offsets in general (e.g. > rowBytes) These strides are pixel counts, so I think it makes sense to leave as ints. reed1 2013/10/30 15:49:52 Ah, then lets rename/document them to make that cl Show quoted text On 2013/10/30 15:44:47, mtklein wrote: > On 2013/10/30 15:15:04, reed1 wrote: > > are these logically size_t? we use size_t for byte-offsets in general (e.g. > > rowBytes) > > These strides are pixel counts, so I think it makes sense to leave as ints. Ah, then lets rename/document them to make that clear. Stephen White 2013/10/30 19:47:17 Done. Show quoted text On 2013/10/30 15:49:52, reed1 wrote: > On 2013/10/30 15:44:47, mtklein wrote: > > On 2013/10/30 15:15:04, reed1 wrote: > > > are these logically size_t? we use size_t for byte-offsets in general (e.g. > > > rowBytes) > > > > These strides are pixel counts, so I think it makes sense to leave as ints. > > Ah, then lets rename/document them to make that clear. Done.
	12

	13 SkMorphologyProc SkDilateXGetPlatformProc();
	reed1 2013/10/30 15:15:04 "if" this list wants to grow in the future, I wond "if" this list wants to grow in the future, I wonder if an enum would be easier to remember... enum SkMorphologyType { kDilateX_SkMorphologyType, ... }; SkMorphologyProc SkGetMorphologyPlatformProc(SkMorphologyType); Stephen White 2013/10/30 19:47:17 I don't forsee the list growing, but I've turned i Show quoted text On 2013/10/30 15:15:04, reed1 wrote: > "if" this list wants to grow in the future, I wonder if an enum would be easier > to remember... > > enum SkMorphologyType { > kDilateX_SkMorphologyType, > ... > }; > > SkMorphologyProc SkGetMorphologyPlatformProc(SkMorphologyType); I don't forsee the list growing, but I've turned it into an enum anyway.
	14 SkMorphologyProc SkDilateYGetPlatformProc();

	15 SkMorphologyProc SkErodeXGetPlatformProc();

	16 SkMorphologyProc SkErodeYGetPlatformProc();

OLD	NEW

« src/effects/SkMorphologyImageFilter.cpp ('K') | « src/effects/SkMorphologyImageFilter.cpp ('k') | src/opts/SkMorphology_opts_SSE2.h » ('j') | src/opts/SkMorphology_opts_SSE2.cpp » ('J')