Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 52593008: Do Else() first for JoinContinuation() in IfBuilder. (Closed)

Created:
7 years, 1 month ago by Benedikt Meurer
Modified:
7 years, 1 month ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Do Else() first for JoinContinuation() in IfBuilder. This is required to make sure that environments are correct for joined continuations. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17464

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/hydrogen.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
7 years, 1 month ago (2013-10-31 07:43:10 UTC) #1
Sven Panne
lgtm
7 years, 1 month ago (2013-10-31 07:53:56 UTC) #2
Benedikt Meurer
7 years, 1 month ago (2013-11-05 08:56:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17464.

Powered by Google App Engine
This is Rietveld 408576698