extensions/browser/guest_view/web_view/web_view_permission_helper.cc - Issue 525793002: Make WebContentsObserver::web_contents() public

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_permission_helper.cc

Issue 525793002: Make WebContentsObserver::web_contents() public (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments addressed Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/web_view/web_view_guest.cc ('k') | extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_permission_helper.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_permission_helper.cc b/extensions/browser/guest_view/web_view/web_view_permission_helper.cc

index 50e191187705e3f01d24dff653b3871067c7da7e..079282b95d983268e3f63ebff46cc277decb0bd6 100644

--- a/extensions/browser/guest_view/web_view/web_view_permission_helper.cc

+++ b/extensions/browser/guest_view/web_view/web_view_permission_helper.cc

@@ -130,10 +130,10 @@ void RecordUserInitiatedUMA(

} // namespace

WebViewPermissionHelper::WebViewPermissionHelper(WebViewGuest* web_view_guest)

- : content::WebContentsObserver(web_view_guest->guest_web_contents()),

- next_permission_request_id_(guestview::kInstanceIDNone),

- web_view_guest_(web_view_guest),

- weak_factory_(this) {

+ : content::WebContentsObserver(web_view_guest->web_contents()),

+ next_permission_request_id_(guestview::kInstanceIDNone),

+ web_view_guest_(web_view_guest),

+ weak_factory_(this) {

web_view_permission_helper_delegate_.reset(

ExtensionsAPIClient::Get()->CreateWebViewPermissionHelperDelegate(

this));